chore: remove deprecated code for next major #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f6a55f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LuLaValva
reviewed
Jan 24, 2025
ArtBlue
reviewed
Jan 24, 2025
|
Should be ready for re-review |
LuLaValva
approved these changes
Jan 27, 2025
This was referenced Jan 27, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went through the code and removed all deprecated code.
Please verify these are okay to remove. If there are additional ones (like fullscreen or drawer dialog), will add them too!
Things I did not change because I was not sure if its okay to remove, but happy to remove:
https://github.com/eBay/skin/blob/master/src/sass/page-grid/page-grid.scss#L57-L63 subgrid
https://github.com/eBay/skin/blob/master/src/sass/variables/_variables.scss#L30 variables (both because it might add too many breaking changes if we add dialogs on top of it, but also which ones need to be removed?)