Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 18.4.0 #2475

Merged
merged 8 commits into from
Oct 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/great-ways-taste.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": minor
---

chore: removed unused storybook files (and percy workflow)
5 changes: 5 additions & 0 deletions .changeset/khaki-worms-hug.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": minor
---

feat(table): added frozen header, frozen column, permanent scrollbars
5 changes: 5 additions & 0 deletions .changeset/little-days-wait.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": patch
---

feat(eek): updated size
5 changes: 5 additions & 0 deletions .changeset/moody-otters-wait.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": minor
---

chore(table): added thead line for scrolling, reverted table contraint
5 changes: 5 additions & 0 deletions .changeset/proud-dodos-cover.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": minor
---

feat(icons): added and modified icons
5 changes: 5 additions & 0 deletions .changeset/real-sheep-cough.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": patch
---

Add description to file preview card
5 changes: 5 additions & 0 deletions .changeset/strong-dingos-suffer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": minor
---

feat(list): new component
25 changes: 13 additions & 12 deletions .github/workflows/pages-html-proofer.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
name: pages-html-proofer

on:
push:
paths:
- 'docs/**'
- '!docs/storybook'
- '.github/workflows/pages-html-proofer.yml'
pull_request:
paths:
- 'docs/**'
- '!docs/storybook'
- '.github/workflows/pages-html-proofer.yml'
# Disabled for now. Will re-enable once we have a better html proofer
# on:
# push:
# paths:
# - 'docs/**'
# - '!docs/storybook'
# - '.github/workflows/pages-html-proofer.yml'
# pull_request:
# paths:
# - 'docs/**'
# - '!docs/storybook'
# - '.github/workflows/pages-html-proofer.yml'

jobs:
pages-html-proofer:
@@ -26,5 +27,5 @@ jobs:
- run: npm run deploy:only
- uses: chabad360/htmlproofer@master
with:
directory: "./_site"
directory: "./_siteDev"
arguments: --disable_external --ignore_empty_alt --allow_hash_href --allow_missing_href
21 changes: 0 additions & 21 deletions .github/workflows/storybook-percy.yml

This file was deleted.

1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
_cdn
_site
_siteDev
site
docs/.jekyll-metadata
node_modules
6 changes: 3 additions & 3 deletions dist/eek/eek.css
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
display: inline-flex;
font-family: Arial, sans-serif;
font-weight: 700;
height: 28px;
height: 24px;
position: relative;
}

@@ -16,7 +16,7 @@
}

.eek .icon--eek-arrow {
width: 11px;
width: 9px;
}

.eek__arrow {
@@ -111,7 +111,7 @@
border-radius: 1px 0 0 1px;
display: inline-flex;
flex-direction: column;
height: 24px;
height: 20px;
margin: 1px;
padding: 0 1px;
}
10 changes: 7 additions & 3 deletions dist/file-preview-card/file-preview-card.css
Original file line number Diff line number Diff line change
@@ -37,6 +37,7 @@ video.file-preview-card__asset {
}

.file-preview-card__asset--fade {
background-color: inherit;
opacity: 0.5;
}

@@ -45,16 +46,19 @@ video.file-preview-card__asset {
width: 40%;
}

.icon-btn.file-preview-card__action {
.file-preview-card__body .icon-btn {
height: var(--spacing-400);
width: var(--spacing-400);
}

.file-preview-card__body > .file-preview-card__action {
position: absolute;
right: var(--spacing-100);
top: var(--spacing-100);
width: var(--spacing-400);
z-index: 1;
}

.file-preview-card__action:dir(rtl) {
.file-preview-card__body > .file-preview-card__action:dir(rtl) {
left: var(--spacing-100);
right: auto;
}
76 changes: 76 additions & 0 deletions dist/list/list.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
.list {
max-width: 480px;
}

.list ul {
list-style: none;
margin: 0;
padding: 0;
}

.list ul li > * {
align-items: center;
background-color: var(
--list-background-color,
var(--color-background-primary)
);
box-sizing: border-box;
color: var(--color-foreground-on-primary);
display: inline-flex;
font-size: var(--font-size-16);
margin-block: 1px;
min-height: var(--spacing-600);
padding: var(--spacing-150) var(--spacing-200);
width: 100%;
}

.list__leading {
margin-inline-end: var(--spacing-200);
}

.list__trailing {
margin-inline-start: var(--spacing-200);
}

.list__body {
flex: 1;
}

.list li > a,
.list li > button {
border: none;
text-align: left;
text-decoration: none;
}

.list li > a:focus,
.list li > a:hover,
.list li > button:focus,
.list li > button:hover {
color: var(--color-foreground-on-primary);
}

.list li > a:active,
.list li > a:focus,
.list li > a:hover,
.list li > button:active,
.list li > button:focus,
.list li > button:hover {
background-color: var(
--list-background-hover-color,
var(--color-state-primary-hover)
);
}

.list hr {
border: 0;
border-top: 1px solid var(--color-stroke-subtle);
height: 1px;
margin-inline: var(--spacing-200);
padding: 0;
}

[dir="rtl"] .list li > a,
[dir="rtl"] .list li > button {
text-align: right;
}
36 changes: 36 additions & 0 deletions dist/mixins/_utility-mixins.scss
Original file line number Diff line number Diff line change
@@ -60,3 +60,39 @@
@mixin inline-flex-items-centered() {
@include flex-items-centered(inline-flex);
}

@mixin scrollbars-permanent($target) {
#{$target} {
-webkit-overflow-scrolling: touch;
scroll-behavior: smooth;
/* stylelint-disable declaration-block-no-duplicate-properties */
-webkit-scroll-snap-type: mandatory;
-webkit-scroll-snap-type: x mandatory;
-ms-scroll-snap-type: mandatory;
-ms-scroll-snap-type: x mandatory;
scroll-snap-type: proximity;
scroll-snap-type: x proximity;
/* stylelint-enable declaration-block-no-duplicate-properties */
}

#{$target}::-webkit-scrollbar {
background-color: var(--color-background-faint);
border-radius: 12px;
}

#{$target}::-webkit-scrollbar:vertical {
width: 6px;
}

#{$target}::-webkit-scrollbar:horizontal {
height: 6px;
}

#{$target}::-webkit-scrollbar-thumb {
background-color: var(--color-foreground-secondary);
border-color: transparent;
border-radius: 12px;
border-right-style: inset;
box-shadow: none;
}
}
7 changes: 7 additions & 0 deletions dist/svg/icon/icon-bids-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions dist/svg/icon/icon-explore-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions dist/svg/icon/icon-explore-24.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions dist/svg/icon/icon-history-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 4 additions & 5 deletions dist/svg/icon/icon-history-24.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 4 additions & 5 deletions dist/svg/icon/icon-history-64.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions dist/svg/icon/icon-item-list-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions dist/svg/icon/icon-item-list-20.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions dist/svg/icon/icon-item-list-24.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions dist/svg/icon/icon-money-stack-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions dist/svg/icon/icon-money-stack-24.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion dist/svg/icon/icon-panel-close-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion dist/svg/icon/icon-panel-close-20.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading