Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): remove redundant store of drs and da params #1394

Merged
merged 3 commits into from
Mar 20, 2025
Merged

fix(store): remove redundant store of drs and da params #1394

merged 3 commits into from
Mar 20, 2025
+36 −180

Conversation

srene
Copy link
Contributor

@srene srene commented Mar 17, 2025

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A

Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

Sorry, something went wrong.

@srene
fixing test
Loading
Loading status checks…
b710055
@srene srene requested a review from a team as a code owner March 17, 2025 11:33
@srene srene marked this pull request as draft March 17, 2025 11:33
@srene srene self-assigned this Mar 17, 2025
@srene srene linked an issue Mar 17, 2025 that may be closed by this pull request
redundant store of DRS and DA params #1373
Closed
@srene srene changed the title fix(store): remove redundant drs and da storing fix(store): remove redundant store of drs and da params Mar 17, 2025
srene added 2 commits March 17, 2025 13:19
@srene
fix tests
Loading
Loading status checks…
14d72d5
@srene
remove unused keys
Loading
Loading status checks…
ad99884
@srene srene marked this pull request as ready for review March 18, 2025 07:48
mtsitrin
mtsitrin approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@mtsitrin mtsitrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omritoptix omritoptix merged commit 8240615 into main Mar 20, 2025
4 checks passed
@omritoptix omritoptix deleted the srene/1373-drs-da-store branch March 20, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin

Assignees

@srene srene

Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redundant store of DRS and DA params
3 participants
@srene @mtsitrin @omritoptix