Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use t.TempDir() instead of os.MkdirTemp #1389

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

tgolang
Copy link
Contributor

@tgolang tgolang commented Mar 8, 2025

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

TempDir() is a method introduced in Go 1.15 for testing.T. It automatically creates a temporary directory and cleans it up after the test is complete, eliminating the hassle of manually handling errors and cleanup. More detail about TempDir https://pkg.go.dev/testing#B.TempDir

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@tgolang tgolang requested a review from a team as a code owner March 8, 2025 07:17
@mtsitrin
Copy link
Contributor

mtsitrin commented Mar 9, 2025

@tgolang linter issues

@tgolang
Copy link
Contributor Author

tgolang commented Mar 10, 2025

@tgolang linter issues

Thanks.

CI passed in my repo. Please approve the workflows. https://github.com/tgolang/dymint/actions

@mtsitrin mtsitrin merged commit eff5288 into dymensionxyz:main Mar 10, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants