Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(da): enable da rotation #1368

Merged
merged 19 commits into from
Feb 13, 2025
Merged

feat(da): enable da rotation #1368

merged 19 commits into from
Feb 13, 2025

Conversation

srene
Copy link
Contributor

@srene srene commented Feb 11, 2025

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner February 11, 2025 10:10
@srene srene self-assigned this Feb 11, 2025
@srene srene marked this pull request as draft February 11, 2025 10:11
@srene srene linked an issue Feb 11, 2025 that may be closed by this pull request
@srene srene marked this pull request as ready for review February 11, 2025 16:17
@srene srene added C:da DA related and removed dym-internal labels Feb 11, 2025
mtsitrin
mtsitrin previously approved these changes Feb 13, 2025
Co-authored-by: Michael Tsitrin <[email protected]>
@mtsitrin mtsitrin merged commit fdd0316 into main Feb 13, 2025
4 checks passed
@mtsitrin mtsitrin deleted the srene/da-transition branch February 13, 2025 14:02
srene added a commit that referenced this pull request Feb 17, 2025
Co-authored-by: Michael Tsitrin <[email protected]>
Co-authored-by: Michael Tsitrin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable da transition
2 participants