fix(metrics): various fixes in metrics #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-when-block-production-paused
danwt
approved these changes
Jan 8, 2025
srene
reviewed
Jan 9, 2025
| @@ -199,6 +196,12 @@ func (m *Manager) applyBlock(block *types.Block, commit *types.Commit, blockMeta | |||
| panic("I'm the new Proposer now. restarting as a proposer") | |||
| } | |||
|
|
|||
| // update metrics | |||
There was a problem hiding this comment.
is it not better to move them before ValidateConfigWithRollappParams()? it can return err on ValidateConfigWithRollappParams or panic for rotation and metrics wont be updated...
There was a problem hiding this comment.
not sure why it needs to be updated on error
the metrics are not for debugging
mtsitrin
deleted the
1221-pending-submissions-metrics-dont-update-when-block-production-paused
branch
srene
pushed a commit
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RollappBlockSizeTxsGaugeLastReceivedDAHeightGaugetoLastValidatedHeightRollappPendingSubmissionsSkewBatches(Pending submissions metrics don't update when block production paused #1221)