Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proto): dependency cycle between rdk, dymint, and rollapp repos #1188

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Oct 30, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@keruch keruch self-assigned this Oct 30, 2024
@keruch keruch requested a review from a team as a code owner October 30, 2024 17:01
@keruch keruch force-pushed the kirill/fix-proto-dependency-cycle branch from 8deff11 to 611fb0a Compare October 30, 2024 17:02
@omritoptix omritoptix merged commit efbf726 into main Oct 31, 2024
6 checks passed
@omritoptix omritoptix deleted the kirill/fix-proto-dependency-cycle branch October 31, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants