feat(manager): create sequencer events populate sequencers list #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mtsitrin
requested changes
Oct 7, 2024
settlement/local/local.go
Outdated
| @@ -206,6 +206,11 @@ func (c *Client) GetProposer() *types.Sequencer { | |||
| return types.NewSequencer(tmPubKey, pubKey.Address().String()) | |||
| } | |||
|
|
|||
| // GetSequencerByAddress returns all sequencer information by its address. Not implemented since it will not be used in mock SL | |||
| func (c *Client) GetSequencerByAddress(address string) (types.Sequencer, error) { | |||
| return types.Sequencer{}, nil | |||
There was a problem hiding this comment.
better to return error with empty sequencer?
There was a problem hiding this comment.
added panic because it shouldnt be called from mock sl
settlement/grpc/grpc.go
Outdated
| @@ -228,6 +228,11 @@ func (c *Client) GetProposer() *types.Sequencer { | |||
| return types.NewSequencer(tmPubKey, pubKey.Address().String()) | |||
| } | |||
|
|
|||
| // GetSequencerByAddress returns all sequencer information by its address. Not implemented since it will not be used in grpc SL | |||
| func (c *Client) GetSequencerByAddress(address string) (types.Sequencer, error) { | |||
| return types.Sequencer{}, nil | |||
There was a problem hiding this comment.
better to return error with empty sequencer?
There was a problem hiding this comment.
added panic because it shouldnt be called from grpc sl
block/manager.go
Outdated
| @@ -194,6 +194,7 @@ func (m *Manager) Start(ctx context.Context) error { | |||
| /* ----------------------------- sequencer mode ----------------------------- */ | |||
| // Subscribe to batch events, to update last submitted height in case batch confirmation was lost. This could happen if the sequencer crash/restarted just after submitting a batch to the settlement and by the time we query the last batch, this batch wasn't accepted yet. | |||
| go uevent.MustSubscribe(ctx, m.Pubsub, "updateSubmittedHeightLoop", settlement.EventQueryNewSettlementBatchAccepted, m.UpdateLastSubmittedHeight, m.logger) | |||
| go uevent.MustSubscribe(ctx, m.Pubsub, "newBondedSequencer", settlement.EventQueryNewBondedSequencer, m.UpdateSequencerSet, m.logger) | |||
There was a problem hiding this comment.
what about full node mode? probably required there as well
There was a problem hiding this comment.
true, moved to before to be called by sequencers and full-nodes
Co-authored-by: Michael Tsitrin <[email protected]>
mtsitrin
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #1015
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: