Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapper for writing assignments #3

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Add wrapper for writing assignments #3

merged 1 commit into from
Jan 27, 2023

Conversation

zertosh
Copy link
Contributor

@zertosh zertosh commented Jan 27, 2023

RFC: If this code looks reasonable, I will flesh out the documentation.

@dtolnay
Copy link
Owner

dtolnay commented Jan 27, 2023

Looks reasonable 👍

@zertosh
Copy link
Contributor Author

zertosh commented Jan 27, 2023

Removed the dedicated tests in favor of doctests

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay changed the title RFC: Add wrapper for writing assignments Add wrapper for writing assignments Jan 27, 2023
@dtolnay dtolnay merged commit a231100 into dtolnay:master Jan 27, 2023
@dtolnay
Copy link
Owner

dtolnay commented Jan 27, 2023

Published in serde_starlark 0.1.11.

@zertosh zertosh deleted the assignment branch January 27, 2023 20:49
facebook-github-bot pushed a commit to facebookincubator/reindeer that referenced this pull request Jan 27, 2023
Summary: Adds `Assignment` from dtolnay/serde-starlark#3

Reviewed By: dtolnay

Differential Revision: D42813469

fbshipit-source-id: d66412bf26a55318d468cd2f0e7465815e227a83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants