-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support external blob #1672
Open
BraveY
wants to merge
32
commits into
dragonflyoss:master
Choose a base branch
from
BraveY:external-blob
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support external blob #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1672 +/- ##
==========================================
- Coverage 60.42% 55.16% -5.26%
==========================================
Files 146 199 +53
Lines 48943 55359 +6416
Branches 46380 46978 +598
==========================================
+ Hits 29573 30541 +968
- Misses 17906 23242 +5336
- Partials 1464 1576 +112
🚀 New features to boost your workflow:
|
9ca650d
to
24a62f1
Compare
Signed-off-by: Yan Song <[email protected]>
Signed-off-by: Yan Song <[email protected]>
Signed-off-by: Yan Song <[email protected]>
Signed-off-by: Yan Song <[email protected]>
Signed-off-by: Yan Song <[email protected]>
Signed-off-by: Yan Song <[email protected]>
- copy snapshotter code to internal package. - add modctl handler to produce nydus attribute pattern. - support push manifest to registry in convert Signed-off-by: Yang Kaiyong <[email protected]>
Signed-off-by: Yan Song <[email protected]>
Signed-off-by: Yan Song <[email protected]>
Signed-off-by: Yan Song <[email protected]>
Signed-off-by: Yan Song <[email protected]>
Ensure that the parent directories of external files are added to the external tree. This change preserves the directory structure and marks all necessary parent directories as external. Signed-off-by: Yang Kaiyong <[email protected]>
- Added detailed comments to the chunk implementation in modctl.go. - Formatted the code to improve readability and consistency. Signed-off-by: Yang Kaiyong <[email protected]>
…nd bootstrap - Eliminate the merge step and directly integrate backend.json and bootstrap into the final bootstrap during the packing process. - When assembling the manifest file, include the original model image's config information and layers. Signed-off-by: Yang Kaiyong <[email protected]>
Reformat the codebase to align with Clippy's linting suggestions. Signed-off-by: Yang Kaiyong <[email protected]>
Signed-off-by: Yan Song <[email protected]>
The chunk size of model image can be configured by `--chunk-size` flag in convert command. Signed-off-by: Yang Kaiyong <[email protected]>
Introduce the ability to use plain HTTP during the nydusify convert command when pushing blobs. This feature is controlled via a dedicated flag, allowing users to opt for plain HTTP communication when needed. Signed-off-by: Yang Kaiyong <[email protected]>
Signed-off-by: Yang Kaiyong <[email protected]>
Signed-off-by: Yang Kaiyong <[email protected]>
Signed-off-by: Yang Kaiyong <[email protected]>
Set file size before calculating block count. Signed-off-by: Yang Kaiyong <[email protected]>
This update enables the `nydusify mount` subcommand to support mounting external large model images. Signed-off-by: Yang Kaiyong <[email protected]>
- Add a new `goreleaser` job in GitHub Actions to handle RPM and DEB packaging. - Introduce a `goreleaser.sh` script to dynamically generate `.goreleaser.yml` configuration. This change enables automated RPM/DEB package generation, improving release efficiency and consistency. Signed-off-by: Yang Kaiyong <[email protected]>
@codecov retest |
Add unit test in external modctl package. Signed-off-by: Yang Kaiyong <[email protected]>
Remove snapshotter convert package to third party. Just a workaround to avoid copying nydus-snapshotter code directly. Signed-off-by: Yang Kaiyong <[email protected]>
Signed-off-by: Yang Kaiyong <[email protected]>
Signed-off-by: Yang Kaiyong <[email protected]>
Signed-off-by: Yang Kaiyong <[email protected]>
Signed-off-by: Yang Kaiyong <[email protected]>
Signed-off-by: Yang Kaiyong <[email protected]>
Signed-off-by: Yang Kaiyong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.