feat(metrics): Update metrics for aliased commands #4819
Conversation
abhijat
changed the title
src/server/main_service.cc
Outdated
| @@ -1234,7 +1234,7 @@ void Service::DispatchCommand(ArgSlice args, SinkReplyBuilder* builder, | |||
|
|
|||
| dfly_cntx->cid = cid; | |||
|
|
|||
| if (!InvokeCmd(cid, args_no_cmd, builder, dfly_cntx)) { | |||
| if (!InvokeCmd(cid, args_no_cmd, builder, dfly_cntx, cmd)) { | |||
There was a problem hiding this comment.
this might break dual word registered commands like ACL ...
There was a problem hiding this comment.
changed so that only aliases are handled specially when counting stats, all other commands use cmd.name, by checking if the passed in command was part of alias map
abhijat
force-pushed
the
abhijat/feat/cmd-alias-metrics
branch
from
62c9812 to
0099f42
Compare
When a call is made to server, its call count and call time is counted against the string it was called with, if the user supplied command was an alias to some other command. Signed-off-by: Abhijat Malviya <[email protected]>
abhijat
force-pushed
the
abhijat/feat/cmd-alias-metrics
branch
from
0099f42 to
f5b7aea
Compare
abhijat
changed the title
abhijat
changed the title
| std::optional<std::string_view> orig_cmd_name = std::nullopt; | ||
| if (registry_.IsAlias(cmd)) { | ||
| orig_cmd_name = cmd; | ||
| } |
There was a problem hiding this comment.
Another alternative to this lookup would be to return more info from FindExtended, maybe a struct with some flags like whether the input was alias or not.
This current approach seems to be simple, although it comes at the expense of an extra hashmap lookup in the command execution path.
The alias map would ideally be small though so this lookup shouldn't be too bad. I would be interested to know reviewers thoughts on this though.
abhijat
changed the title
When a call is made to server, its call count and call time is counted against the string it was called with, if the command was found to be an alias.
Fixes #4068
Follow up PR to #4782