feat(search_family): Add basic support for the FT.CONFIG command #4779
+287
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BagritsevichStepan
changed the title
BorysTheDev
reviewed
Mar 17, 2025
BorysTheDev
reviewed
Mar 17, 2025
BorysTheDev
reviewed
Mar 17, 2025
| << CI{"FT.ALTER", CO::WRITE | CO::GLOBAL_TRANS, -3, 0, 0, acl::FT_SEARCH}.HFUNC(FtAlter) | ||
| << CI{"FT.DROPINDEX", CO::WRITE | CO::GLOBAL_TRANS, -2, 0, 0, acl::FT_SEARCH}.HFUNC( | ||
| FtDropIndex) | ||
| << CI{"FT.CONFIG", CO::WRITE | CO::GLOBAL_TRANS, -3, 0, 0, acl::FT_SEARCH}.HFUNC(FtConfig) |
There was a problem hiding this comment.
I'm also not sure what options should I set here, But I think since we are going to remove mutexes it sould be GLOBAL_TRANS
There was a problem hiding this comment.
I think it should be GLOBAL anycase
There was a problem hiding this comment.
Maybe you also need to add NO_KEY_TRANSACTIONAL
BagritsevichStepan
force-pushed
the
search/add-basic-support-of-ft-config-command
branch
from
fee09ba to
1d82c85
Compare
fixes dragonflydb#4352 Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan
force-pushed
the
search/add-basic-support-of-ft-config-command
branch
from
1d82c85 to
1aabaed
Compare
BorysTheDev
reviewed
Mar 20, 2025
| DVLOG(2) << "Setting " << option << " to " << value; | ||
|
|
||
| auto cb = [option, value](util::ProactorBase*) { UpdateConfigOption(option, value); }; | ||
| server_family_->service().proactor_pool().AwaitFiberOnAll(std::move(cb)); |
There was a problem hiding this comment.
You don't meed server_family, you can use shard_set->pool()->AwaitFiberOnAll
BorysTheDev
reviewed
Mar 20, 2025
| @@ -24,8 +24,10 @@ | |||
| #include "server/conn_context.h" | |||
| #include "server/container_utils.h" | |||
| #include "server/engine_shard_set.h" | |||
| #include "server/main_service.h" | |||
BorysTheDev
reviewed
Mar 20, 2025
| #include "server/search/aggregator.h" | ||
| #include "server/search/doc_index.h" | ||
| #include "server/server_family.h" |
BorysTheDev
reviewed
Mar 20, 2025
Comment on lines
+1083
to
+1098
| void SearchFamily::FtConfigSet(CmdArgList args, const CommandContext& cmd_cntx) { | ||
| CmdArgParser parser{args}; | ||
| auto* rb = static_cast<RedisReplyBuilder*>(cmd_cntx.rb); | ||
|
|
||
| string_view option = parser.Next(); | ||
| uint64_t value = parser.Next<uint64_t>(); | ||
|
|
||
| if (auto err = parser.Error(); err) | ||
| return rb->SendError(err->MakeReply()); | ||
|
|
||
| auto option_exists = FindOptionsMapValue(kConfigOptions, option); | ||
| if (option_exists) { | ||
| DVLOG(2) << "Setting " << option << " to " << value; | ||
|
|
||
| auto cb = [option, value](util::ProactorBase*) { UpdateConfigOption(option, value); }; | ||
| server_family_->service().proactor_pool().AwaitFiberOnAll(std::move(cb)); |
There was a problem hiding this comment.
what will happen if we have 2 simultaneous commands?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4352
Add basic support of the
MAXSEARCHRESULTSandMAXAGGREGATERESULTSoptions.Issue with other options: #4780