Fix runtime pack selection for dotnet build with PublishAot=true and PublishAotUsingRuntimePack=true
#34640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d PublishAotUsingRuntimePack=true
dotnet-issue-labeler
bot
added
Area-WebSDK
untriaged
rolfbjarne
approved these changes
Aug 15, 2023
steveisok
approved these changes
Aug 16, 2023
|
This needs to go into rc1 as well. I'm not sure what the rules are in sdk for that. |
|
This technically went into .net 9 (main turned into this today). You'll need to cherry pick PRs to release/8.0.1xx (if missing rc1 is ok but it must be in 8.0.100) and release/8.0.1xx-rc1 (if it must be in rc1 as well). |
|
/backport to release/8.0.1xx-rc1 |
Did Marc add |
|
Looks like there are a couple kinks to work out still 😅 |
This was referenced Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
dotnet buildinstead ofdotnet publishwe are not really running NativeAOT compilation. We are just running a regular build with additional trimming analyzers and options. Thus we are not supposed to use the NativeAOT runtime pack.