Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Set HttpActivityPropagationSupport=false for optimized builds #22430

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

jfversluis
Copy link
Member

@jfversluis jfversluis commented Mar 19, 2025

We set HttpActivityPropagationSupport=false when Optimize=true, to match what Android does (dotnet/android#9933).

Fixes #22429.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jfversluis
Copy link
Member Author

Over on Android they opted to use the Optimize property instead is that something that is applicable here?

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne changed the title Set HttpActivityPropagationSupport=true for non-Release builds Set HttpActivityPropagationSupport=false for optimized builds Mar 21, 2025
@rolfbjarne rolfbjarne changed the title Set HttpActivityPropagationSupport=false for optimized builds [dotnet] Set HttpActivityPropagationSupport=false for optimized builds Mar 21, 2025
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #7faa83f] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 7faa83f8826cf68a591b1b2bba1f2ad7e7f98f63 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #7faa83f] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 7faa83f8826cf68a591b1b2bba1f2ad7e7f98f63 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #7faa83f] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 7faa83f8826cf68a591b1b2bba1f2ad7e7f98f63 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7faa83f] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 7faa83f8826cf68a591b1b2bba1f2ad7e7f98f63 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7faa83f] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 7faa83f8826cf68a591b1b2bba1f2ad7e7f98f63 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7faa83f] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 7faa83f8826cf68a591b1b2bba1f2ad7e7f98f63 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7faa83f] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 7faa83f8826cf68a591b1b2bba1f2ad7e7f98f63 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7faa83f8826cf68a591b1b2bba1f2ad7e7f98f63 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #7faa83f] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 7faa83f8826cf68a591b1b2bba1f2ad7e7f98f63 [PR build]

@rolfbjarne rolfbjarne merged commit be28d2e into main Mar 25, 2025
47 checks passed
@rolfbjarne rolfbjarne deleted the dev/fix-22429 branch March 25, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set HttpActivityPropagationSupport=true for non-Release builds
5 participants