[RGen] Add BindFrom factory method that will return the correct declaration. #22114

mandel-macaque · 2025-02-05T01:06:15Z

This method is the final step to be able to generate the aux variable for a BindFrom decorated parameter. We just need to perform a switch on the type of the BindFrom attribute to decide the final declaration needed.

…ration. This method is the final step to be able to generate the aux variable for a BindFrom decorated parameter. We just need to perform a switch on the type of the BindFrom attribute to decide the final declaration needed.

github-actions · 2025-02-06T03:34:02Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2025-02-06T04:42:49Z

✅ [PR Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: f53132abd27eaf8ad5d019425ca3843bbdd2079f [PR build]

vs-mobiletools-engineering-service2 · 2025-02-06T04:45:08Z

✅ [PR Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: f53132abd27eaf8ad5d019425ca3843bbdd2079f [PR build]

vs-mobiletools-engineering-service2 · 2025-02-06T04:52:12Z

✅ [PR Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: f53132abd27eaf8ad5d019425ca3843bbdd2079f [PR build]

vs-mobiletools-engineering-service2 · 2025-02-06T05:04:54Z

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: f53132abd27eaf8ad5d019425ca3843bbdd2079f [PR build]

vs-mobiletools-engineering-service2 · 2025-02-06T05:06:23Z

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: f53132abd27eaf8ad5d019425ca3843bbdd2079f [PR build]

vs-mobiletools-engineering-service2 · 2025-02-06T05:06:42Z

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: f53132abd27eaf8ad5d019425ca3843bbdd2079f [PR build]

vs-mobiletools-engineering-service2 · 2025-02-06T05:06:43Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: f53132abd27eaf8ad5d019425ca3843bbdd2079f [PR build]

vs-mobiletools-engineering-service2 · 2025-02-06T05:17:19Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: f53132abd27eaf8ad5d019425ca3843bbdd2079f [PR build]

vs-mobiletools-engineering-service2 · 2025-02-06T05:29:32Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: f53132abd27eaf8ad5d019425ca3843bbdd2079f [PR build]

vs-mobiletools-engineering-service2 · 2025-02-06T07:28:37Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 111 tests passed.

Failures

❌ monotouch tests (macOS)

1 tests failed, 8 tests passed.

monotouch-test/macOS/Debug (managed static registrar): Failed (Test run failed.
Tests run: 3104 Passed: 2998 Inconclusive: 8 Failed: 1 Ignored: 105)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: f53132abd27eaf8ad5d019425ca3843bbdd2079f [PR build]

mandel-macaque · 2025-02-06T11:30:14Z

Failing tests are unrelated to the changes.

This comment has been minimized.

Sign in to view

mandel-macaque force-pushed the dev/mandel/aux-variable-smartenum branch from 96c8957 to 99e4ceb Compare February 5, 2025 19:04

Base automatically changed from dev/mandel/aux-variable-smartenum to main February 5, 2025 21:50

mandel-macaque force-pushed the dev/mandel/aux-variable-bindfrom-param branch from db48911 to 8386b86 Compare February 6, 2025 03:29

Auto-format source code

f53132a

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 94d784e into main Feb 6, 2025
41 of 43 checks passed

mandel-macaque deleted the dev/mandel/aux-variable-bindfrom-param branch February 6, 2025 11:30

[RGen] Add BindFrom factory method that will return the correct declaration. #22114

[RGen] Add BindFrom factory method that will return the correct declaration. #22114

Conversation

mandel-macaque commented Feb 5, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 6, 2025

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 6, 2025

✅ [PR Build] Build passed (Build packages) ✅

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 6, 2025

✅ [PR Build] Build passed (Detect API changes) ✅

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 6, 2025

✅ [PR Build] Build passed (Build macOS tests) ✅

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 6, 2025

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Feb 6, 2025

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Feb 6, 2025

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Feb 6, 2025

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 6, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Feb 6, 2025

💻 [CI Build] Windows Integration Tests passed 💻

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 6, 2025

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ monotouch tests (macOS)

Successes

mandel-macaque commented Feb 6, 2025