[RGen] Add an implementation of Stret.IsBuiltInType with Roslyn. #22036

mandel-macaque · 2025-01-23T21:23:38Z

Roslyn has no access to reflection. Add an implementation of the IsBuiltInType method using the Roslyn APIs and test one method against the other. Tests show that the implementations return the same values for the same inputs.

github-actions · 2025-01-23T23:36:49Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

Copilot

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

tests/rgen/Microsoft.Macios.Generator.Tests/Microsoft.Macios.Generator.Tests.csproj: Language not supported

Comments suppressed due to low confidence (1)

src/rgen/Microsoft.Macios.Generator/Extensions/TypeSymbolExtensions.Core.cs:254

The TryGetBuiltInTypeSize method does not handle the case where SpecialType is None. This could potentially lead to incorrect behavior. Add a case to handle SpecialType.None.

var (currentSize, result) = symbolInfo switch { { SpecialType: SpecialType.System_Void } => (0, true), { ContainingNamespace: "ObjCRuntime", Name: "NativeHandle" } => (is64bits ? 8 : 4, true), { ContainingNamespace: "System.Runtime.InteropServices", Name: "NFloat" } => (is64bits ? 8 : 4, true), { ContainingNamespace: "System", Name: "Char" or "Boolean" or "SByte" or "Byte" } => (1, true), { ContainingNamespace: "System", Name: "Int16" or "UInt16" } => (2, true), { ContainingNamespace: "System", Name: "Single" or "Int32" or "UInt32" } => (4, true), { ContainingNamespace: "System", Name: "Double" or "Int64" or "UInt64" } => (8, true), { ContainingNamespace: "System", Name: "IntPtr" or "UIntPtr" or "nuint" or "nint" } => (is64bits ? 8 : 4, true), _ => (0, false) };

Copilot · 2025-01-24T00:45:48Z

tests/rgen/Microsoft.Macios.Generator.Tests/Extensions/TypeSymbolExtensionsSizeTests.cs

+	NFloat Test { get; set; }
+}
+";
+			yield return [nfloatProperty, typeof (NFloat)];


The yield return statement should use parentheses for the array. Change it to yield return new object[] { nfloatProperty, typeof (NFloat) };.

Suggested change

yield return [nfloatProperty, typeof (NFloat)];

yield return new object[] { nfloatProperty, typeof (NFloat) };

mandel-macaque · 2025-01-24T12:02:46Z

Test failures are unrelated to the change and the dotnettests worked on other platforms.

vs-mobiletools-engineering-service2 · 2025-01-24T12:58:22Z

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: fffd48781ac3dd70ee4a1ce60ebf196fa7878aa9 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-24T13:01:38Z

✅ [CI Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: fffd48781ac3dd70ee4a1ce60ebf196fa7878aa9 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-24T13:21:36Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: fffd48781ac3dd70ee4a1ce60ebf196fa7878aa9 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-24T13:34:11Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fffd48781ac3dd70ee4a1ce60ebf196fa7878aa9 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-24T13:38:31Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: fffd48781ac3dd70ee4a1ce60ebf196fa7878aa9 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-24T13:38:48Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: fffd48781ac3dd70ee4a1ce60ebf196fa7878aa9 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-24T13:40:38Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: fffd48781ac3dd70ee4a1ce60ebf196fa7878aa9 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-24T13:41:16Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: fffd48781ac3dd70ee4a1ce60ebf196fa7878aa9 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-24T13:41:19Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: fffd48781ac3dd70ee4a1ce60ebf196fa7878aa9 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-24T16:25:53Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 119 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: fffd48781ac3dd70ee4a1ce60ebf196fa7878aa9 [PR build]

This comment has been minimized.

Sign in to view

mandel-macaque and others added 2 commits January 23, 2025 18:32

Merge branch 'main' into dev/mandel/stret-is-built-in-type-roslyn

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

48966b7

Auto-format source code

a7be8a4

dalexsoto approved these changes Jan 23, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

samhouts requested a review from Copilot January 24, 2025 00:45

Copilot AI reviewed Jan 24, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque merged commit fffd487 into main Jan 24, 2025
39 of 43 checks passed

mandel-macaque deleted the dev/mandel/stret-is-built-in-type-roslyn branch January 24, 2025 12:15

	yield return [nfloatProperty, typeof (NFloat)];
	yield return new object[] { nfloatProperty, typeof (NFloat) };

[RGen] Add an implementation of Stret.IsBuiltInType with Roslyn. #22036

[RGen] Add an implementation of Stret.IsBuiltInType with Roslyn. #22036

Conversation

mandel-macaque commented Jan 23, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 23, 2025

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI Jan 24, 2025

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque commented Jan 24, 2025

vs-mobiletools-engineering-service2 commented Jan 24, 2025

✅ [CI Build] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Jan 24, 2025

✅ [CI Build] Build passed (Detect API changes) ✅

vs-mobiletools-engineering-service2 commented Jan 24, 2025

✅ [CI Build] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Jan 24, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Jan 24, 2025

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Jan 24, 2025

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Jan 24, 2025

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Jan 24, 2025

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Jan 24, 2025

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Jan 24, 2025

🚀 [CI Build] Test results 🚀

Test results

Tests counts