[msbuild/dotnet/src] Misc exception marshalling improvements. #21892

rolfbjarne · 2025-01-03T15:15:25Z

Make the MSBuild properties to select the exception marshaling modes public and documented.
Document the relevant managed APIs.
Remove the default constructors for the event args types, and replace with
constructors that take all the properties (this makes nullability work
better).

* Make the MSBuild properties to select the exception marshaling modes public and documented. * Document the relevant managed APIs. * Remove the default constructors for the event args types, and replace with constructors that take all the properties (this makes nullability work better).

rolfbjarne · 2025-01-03T15:15:29Z

/azp run xamarin-macios-pr,xamarin-macios-pr-apidiff

azure-pipelines · 2025-01-03T15:15:49Z

Azure Pipelines successfully started running 1 pipeline(s).

github-actions · 2025-01-03T15:19:22Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

rolfbjarne · 2025-01-03T16:15:27Z

/azp run xamarin-macios-pr,xamarin-macios-pr-apidiff

azure-pipelines · 2025-01-03T16:16:02Z

Azure Pipelines successfully started running 1 pipeline(s).

…ption-marshalling-modes

rolfbjarne · 2025-01-07T11:26:29Z

/azp run xamarin-macios-pr,xamarin-macios-pr-apidiff

azure-pipelines · 2025-01-07T11:26:49Z

Azure Pipelines successfully started running 1 pipeline(s).

rolfbjarne · 2025-01-08T07:34:02Z

/azp run xamarin-macios-pr,xamarin-macios-pr-apidiff

azure-pipelines · 2025-01-08T07:34:19Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2025-01-09T09:49:35Z

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 544516d8c7203412c986f014dfa37cf101ef809f [PR build]

vs-mobiletools-engineering-service2 · 2025-01-09T10:00:30Z

✅ [CI Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 544516d8c7203412c986f014dfa37cf101ef809f [PR build]

vs-mobiletools-engineering-service2 · 2025-01-09T10:15:01Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 544516d8c7203412c986f014dfa37cf101ef809f [PR build]

vs-mobiletools-engineering-service2 · 2025-01-09T10:32:24Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 544516d8c7203412c986f014dfa37cf101ef809f [PR build]

vs-mobiletools-engineering-service2 · 2025-01-09T10:35:16Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 544516d8c7203412c986f014dfa37cf101ef809f [PR build]

vs-mobiletools-engineering-service2 · 2025-01-09T10:35:43Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 544516d8c7203412c986f014dfa37cf101ef809f [PR build]

vs-mobiletools-engineering-service2 · 2025-01-09T10:37:36Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 544516d8c7203412c986f014dfa37cf101ef809f [PR build]

vs-mobiletools-engineering-service2 · 2025-01-09T10:37:37Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 544516d8c7203412c986f014dfa37cf101ef809f [PR build]

vs-mobiletools-engineering-service2 · 2025-01-09T10:40:32Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 544516d8c7203412c986f014dfa37cf101ef809f [PR build]

vs-mobiletools-engineering-service2 · 2025-01-09T13:04:04Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 0 tests failed, 106 tests passed.

Failures

❌ dotnettests tests (macOS)

🔥 Failed catastrophically on VSTS: test results - dotnettests_macos (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 544516d8c7203412c986f014dfa37cf101ef809f [PR build]

Auto-format source code

Loading
Loading status checks…

33e1064

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/elevate-exce…

d80f7d1

…ption-marshalling-modes

rolfbjarne marked this pull request as ready for review January 7, 2025 11:21

rolfbjarne requested review from emaf and mauroa as code owners January 7, 2025 11:21

Update cecil tests

Loading
Loading status checks…

2cd678d

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jan 7, 2025

View reviewed changes

mandel-macaque approved these changes Jan 7, 2025

View reviewed changes

mauroa approved these changes Jan 7, 2025

View reviewed changes

emaf approved these changes Jan 7, 2025

View reviewed changes

Merge branch 'main' into dev/rolf/elevate-exception-marshalling-modes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

f93e09f

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 544516d into main Jan 9, 2025
48 checks passed

rolfbjarne deleted the dev/rolf/elevate-exception-marshalling-modes branch January 9, 2025 06:55

[msbuild/dotnet/src] Misc exception marshalling improvements. #21892

[msbuild/dotnet/src] Misc exception marshalling improvements. #21892

Conversation

rolfbjarne commented Jan 3, 2025

rolfbjarne commented Jan 3, 2025

azure-pipelines bot commented Jan 3, 2025

github-actions bot commented Jan 3, 2025

⚠️ Your code has been reformatted. ⚠️

rolfbjarne commented Jan 3, 2025

azure-pipelines bot commented Jan 3, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Jan 7, 2025

azure-pipelines bot commented Jan 7, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Jan 8, 2025

azure-pipelines bot commented Jan 8, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 9, 2025

✅ [CI Build] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Jan 9, 2025

✅ [CI Build] Build passed (Detect API changes) ✅

vs-mobiletools-engineering-service2 commented Jan 9, 2025

✅ [CI Build] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Jan 9, 2025

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Jan 9, 2025

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Jan 9, 2025

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Jan 9, 2025

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Jan 9, 2025

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Jan 9, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Jan 9, 2025

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ dotnettests tests (macOS)

Successes