[ci] Simplify shipping drop metadata names #21003
Conversation
Using the $(System.JobAttempt) variable in the drop metadata artifact name is problematic. In some cases the drop artifacts created by the nuget-msi-convert job will be used by a different job, and the job attempt number will not necessarily match if any jobs are re-ran.
📚 [CI Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
|
This needs to be merged alongside https://github.com/xamarin/yaml-templates/pull/329, likely to be done early next week. |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 170 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
| @@ -150,7 +150,7 @@ stages: | |||
|
|
|||
| - task: DownloadPipelineArtifact@2 | |||
| inputs: | |||
| artifactName: DropMetadata-$(Build.BuildId)-nugets-$(System.JobAttempt) | |||
| artifactName: DropMetadata-shipping-nugets | |||
There was a problem hiding this comment.
What happens when there is a second run? AFAIK in the second run it will fail. I remember that this was added by @rolfbjarne for a reason. Perse it looks good, I just want to make sure we are not missing a corner case.
There was a problem hiding this comment.
Since the upload is done in the new template context outputs section, it is the last step that will run as part of the job. I don't believe it will be possible for the job to fail before this artifact is created and have the artifact still be uploaded. There is also a new dropMetadataPrefixName parameter on the template that can be set if individual repos run into other corner cases or issues here and need more control over naming.
Using the $(System.JobAttempt) variable in the drop metadata artifact name is problematic. In some cases the drop artifacts created by the nuget-msi-convert job will be used by a different job, and the job attempt number will not necessarily match if any jobs are re-ran.
Using the $(System.JobAttempt) variable in the drop metadata artifact
name is problematic. In some cases the drop artifacts created by the
nuget-msi-convert job will be used by a different job, and the job
attempt number will not necessarily match if any jobs are re-ran.