[msbuild] Don't try to bundle the BouncyCastle.Crypto library anymore. #20044
Conversation
A recent bump in the HotRestartVersion seems to be to a version of Hot Restart that doesn't need/provide the BouncyCastle.Crypto library. Unfortunately due to another issue, the bump didn't actually bring in the updated Hot Restart version (the required NuGet packages weren't published to a feed we subscribe to, so we silently [1] got a different version of the Hot Restart packages). This means our build didn't break in the actual bump, but only when the corresponding Hot Restart package versions were published to the designated feeds (i.e. yesterday). [1]: We got a warning, but no build error. dotnet#20043 fixes this problem.
|
🔥 Failed to compare API and create generator diff 🔥 Error: 'make' failed for the hash 70530a8. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
❌ [CI Build] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
|
Merging since the build is at least working. |
|
/sudo backport release/9.0.1xx-preview1 |
|
Backport Job to branch release/9.0.1xx-preview1 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9043843 for more details. |
…stle.Crypto library anymore. (#20057) A recent bump in the HotRestartVersion seems to be to a version of Hot Restart that doesn't need/provide the BouncyCastle.Crypto library. Unfortunately due to another issue, the bump didn't actually bring in the updated Hot Restart version (the required NuGet packages weren't published to a feed we subscribe to, so we silently [1] got a different version of the Hot Restart packages). This means our build didn't break in the actual bump, but only when the corresponding Hot Restart package versions were published to the designated feeds (i.e. yesterday). [1]: We got a warning, but no build error. #20043 fixes this problem. Backport of #20044
A recent bump in the HotRestartVersion seems to be to a version of Hot Restart
that doesn't need/provide the BouncyCastle.Crypto library.
Unfortunately due to another issue, the bump didn't actually bring in the
updated Hot Restart version (the required NuGet packages weren't published to
a feed we subscribe to, so we silently [1] got a different version of the Hot
Restart packages). This means our build didn't break in the actual bump, but
only when the corresponding Hot Restart package versions were published to the
designated feeds (i.e. yesterday).
[1]: We got a warning, but no build error. #20043 fixes this problem.