-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppKit] Remove [NSImage imageWithSymbolName:bundle:variableValue:] from Mac Catalyst. #19320
[AppKit] Remove [NSImage imageWithSymbolName:bundle:variableValue:] from Mac Catalyst. #19320
Conversation
…rom Mac Catalyst. It doesn't exist there, and it also fails a test.
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
❗ API diff for current PR / commit (Breaking changes)Legacy Xamarin (No breaking changes)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 2 tests failed, 233 tests passed. Failures❌ monotouch tests [attempt 2]
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. [attempt 2] Html Report (VSDrops) Download Pipeline on Agent |
/sudo backport release/8.0.1xx |
Backport Job to branch release/8.0.1xx Created! The magic is happening here |
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2450) |
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8591035 for more details. |
…rom Mac Catalyst. (dotnet#19320) It doesn't exist there, and it also fails a test: [FAIL] StaticMethods : 1 errors found in 3389 static selector validated: AppKit.NSImage : imageWithSymbolName:bundle:variableValue: Expected: 0 But was: 1
Backported manually in #19338. |
It doesn't exist there, and it also fails a test: