Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppKit/UIKit] Adjust a few availability attributes in NS[Mutable]ParagraphStyle. Fixes #19209. #19211

Merged
merged 2 commits into from
Oct 19, 2023
Merged

[AppKit/UIKit] Adjust a few availability attributes in NS[Mutable]ParagraphStyle. Fixes #19209. #19211

merged 2 commits into from
Oct 19, 2023

Conversation

rolfbjarne
Copy link
Member

Both headers and documentation agree that:

  • The TextLists and LineBreakStrategy properties are available in all OS
    versions we support, so adjust the availability attributes accordingly.

  • While the NSLineBreakStrategy enum is supposedly not available in all OS
    versions we support, the NSLineBreakStrategy.PushOut enum value is. This
    doesn't make much sense, so I've made our enum available in all OS versions

    • the PushOut enum value as well. All the other enum values are only
      available in iOS 14+ (according to docs + headers).

Fixes #19209.

@rolfbjarne
[AppKit/UIKit] Adjust a few availability attributes in NS[Mutable]Par…
3c5f22b 
…agraphStyle. Fixes dotnet#19209.

Both headers and documentation agree that:

* The TextLists and LineBreakStrategy properties are available in all OS
  versions we support, so adjust the availability attributes accordingly.

* While the NSLineBreakStrategy enum is supposedly not available in all OS
  versions we support, the NSLineBreakStrategy.PushOut enum value is. This
  doesn't make much sense, so I've made our enum available in all OS versions
  + the PushOut enum value as well. All the other enum values are only
  available in iOS 14+ (according to docs + headers).

Fixes dotnet#19209.
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
haritha-mohan
haritha-mohan reviewed Oct 16, 2023
View reviewed changes
src/xkit.cs Outdated
Comment on lines 1864 to 1865
[NoWatch, MacCatalyst (13, 1)]
[NoMacCatalyst]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't really a part of this pr's changes, but why do we have conflicting attrs here? based on docs it is available starting from mac cat 13.1+, so seems a bit weird having [NoMacCatalyst] here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like an old c&p mistake. I'll fix it too.

tj-devel709
tj-devel709 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@tj-devel709 tj-devel709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am curious about Haritha's comment, but other than that LGTM

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 0fc1add126762fe198b107ca9a9abc6d64387dd5 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
.NET (No breaking changes)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: vsdrops gist (No breaking changes)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0fc1add126762fe198b107ca9a9abc6d64387dd5 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 233 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 39 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0fc1add126762fe198b107ca9a9abc6d64387dd5 [PR build]

@rolfbjarne rolfbjarne merged commit 952c071 into dotnet:main Oct 19, 2023
@rolfbjarne rolfbjarne deleted the issue-nsparagraphstyle-issue-19209 branch October 19, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haritha-mohan haritha-mohan haritha-mohan left review comments

@dalexsoto dalexsoto dalexsoto approved these changes

@stephen-hawley stephen-hawley stephen-hawley approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect SupportedOSPlatform attributes on various properties
6 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @stephen-hawley @tj-devel709 @haritha-mohan