[HealthKitUI] Add support for Xcode 15 #19017
Conversation
|
src/healthkitui.cs
Outdated
|
|
||
| [Export ("setAuthorizationViewControllerPresenter:")] | ||
| void SetAuthorizationViewControllerPresenter ([NullAllowed] UIViewController authorizationViewControllerPresenter); | ||
| } |
There was a problem hiding this comment.
I vote for doing this inline in the 'HKHealthStore' class rather than a category in this file. I'll let @rolfbjarne or @dalexsoto decide.
There was a problem hiding this comment.
Yah I think I agree, inline this as a property inside interface HKHealthStore
[NullAllowed, Export ("authorizationViewControllerPresenter")]
UIViewController AuthorizationViewControllerPresenter { get; set; }
There was a problem hiding this comment.
Yes, that would actually allow us to make it a property instead of a Set/Get method pair.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/healthkitui.cs
Outdated
|
|
||
| [Export ("setAuthorizationViewControllerPresenter:")] | ||
| void SetAuthorizationViewControllerPresenter ([NullAllowed] UIViewController authorizationViewControllerPresenter); | ||
| } |
There was a problem hiding this comment.
Yah I think I agree, inline this as a property inside interface HKHealthStore
[NullAllowed, Export ("authorizationViewControllerPresenter")]
UIViewController AuthorizationViewControllerPresenter { get; set; }
| using UIViewController = AppKit.NSViewController; | ||
| #else | ||
| using UIKit; | ||
| using NSViewController = Foundation.NSObject; |
There was a problem hiding this comment.
this isn't really necessary in the context of this PR but thought it would be good to include to maintain consistency b/w platforms if there is a UI/NSViewController use case in the future..
|
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 238 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.