Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Fix null check when validating Hot Restart app identifier #18546

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[msbuild] Fix null check when validating Hot Restart app identifier #18546

merged 1 commit into from
Jul 10, 2023

Conversation

emaf
Copy link
Contributor

@emaf emaf commented Jul 10, 2023 •
edited by samhouts
Loading

The detection of signing identities should fail if we could not build a valid app id. This code originally checked for null (AppId == null) and was replaced by is not null as part of 36af029#diff-ff4502eb16b65dc59bb7de2bf980024260e83d7b97fef727c9c033374f2b3533R106.

fixes dotnet/maui#15564

@emaf
[msbuild] Fix null check when validating Hot Restart app identifier
c84583e 
The detection of signing identities should fail if we could not build a valid app id. This code originally checked for null (`AppId == null`) and was replaced by `is not null` as part of 36af029#diff-ff4502eb16b65dc59bb7de2bf980024260e83d7b97fef727c9c033374f2b3533R106.
@emaf emaf requested review from mauroa and rolfbjarne as code owners July 10, 2023 17:16
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: c84583e4256a7f84bacfd2a880edd68d474255fc [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: c84583e4256a7f84bacfd2a880edd68d474255fc [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 35 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c84583e4256a7f84bacfd2a880edd68d474255fc [PR build]

@dalexsoto dalexsoto merged commit e7b7d16 into main Jul 10, 2023
@dalexsoto dalexsoto deleted the dev/ema/main-1 branch July 10, 2023 22:36
ivanpovazan pushed a commit to ivanpovazan/xamarin-macios that referenced this pull request Jul 26, 2023
@emaf @ivanpovazan
[msbuild] Fix null check when validating Hot Restart app identifier (d…
d228990 
…otnet#18546)

The detection of signing identities should fail if we could not build a
valid app id. This code originally checked for null (`AppId == null`)
and was replaced by `is not null` as part of
dotnet@36af029#diff-ff4502eb16b65dc59bb7de2bf980024260e83d7b97fef727c9c033374f2b3533R106.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@stephen-hawley stephen-hawley stephen-hawley approved these changes

@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne rolfbjarne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.net 8 preview 4 HotRestart prevents launching iOS app
5 participants
@emaf @vs-mobiletools-engineering-service2 @dalexsoto @mandel-macaque @stephen-hawley