-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0.2xx-xcode14.3] [msbuild] Fix calling the GetFileSystemEntries task on Windows when not connected to a Mac. #18299
Conversation
…ot connected to a Mac. Given the following truths: * A task will (try to) connect to a Mac if its SessionId property isn't empty. * The BuildSessionId property is always set on Windows when building from an IDE (even if not connected to a remote Mac). It stands to reason that we can't use BuildSessionId to distinguish between connected/not conected status on Windows. Instead introduce a new property, BuildSessionIdIfConnected, which is only set if connected to a Mac (i.e. if 'IsMacEnabled=true'). Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1808448 (second attempt).
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 79 tests passed 🎉 Tests counts
Pipeline on Agent |
Given the following truths:
It stands to reason that we can't use BuildSessionId to distinguish between
connected/not conected status on Windows. Instead introduce a new property,
BuildSessionIdIfConnected, which is only set if connected to a Mac (i.e. if
'IsMacEnabled=true').
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1808448 (second attempt).
Backport of #18287