-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0.1xx-xcode14-rc2] [illink] Ensure we replace the dotnet SDK path in the _ExtraTrimmerArgs for remote builds. #16311
Conversation
…DK path in the _ExtraTrimmerArgs for remote builds. From net7, the original ILLInk targets are adding a new link attribute pointing to a supressions file inside the ILLink tasks folder, e.g: '--link-attributes "C:\Program Files\dotnet\sdk\7.0.100-rc.2.22477.23\Sdks\Microsoft.NET.ILLink.Tasks\build\6.0_suppressions.xml"'. For remote builds, we need to replace the original dotnet folder with the XMA dotnet folder in the Mac, so in our override targets we replace this value before passing it to the ILLink task Backport of dotnet#16294.
❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌No test package could be found for tests on macOS Mac Catalina (10.15) Pipeline on Agent |
🔥 Failed to compare API and create generator diff 🔥 Error: 'make install' failed for the hash 044af24. Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 19 tests crashed, 0 tests failed, 0 tests passed. Failures❌ bcl tests🔥 Failed catastrophically on VSTS: simulator tests - bcl (no summary found). Html Report (VSDrops) Download ❌ cecil tests🔥 Failed catastrophically on VSTS: simulator tests - cecil (no summary found). Html Report (VSDrops) Download ❌ dotnettests tests🔥 Failed catastrophically on VSTS: simulator tests - dotnettests (no summary found). Html Report (VSDrops) Download ❌ fsharp tests🔥 Failed catastrophically on VSTS: simulator tests - fsharp (no summary found). Html Report (VSDrops) Download ❌ framework tests🔥 Failed catastrophically on VSTS: simulator tests - framework (no summary found). Html Report (VSDrops) Download ❌ generator tests🔥 Failed catastrophically on VSTS: simulator tests - generator (no summary found). Html Report (VSDrops) Download ❌ interdependent_binding_projects tests🔥 Failed catastrophically on VSTS: simulator tests - interdependent_binding_projects (no summary found). Html Report (VSDrops) Download ❌ install_source tests🔥 Failed catastrophically on VSTS: simulator tests - install_source (no summary found). Html Report (VSDrops) Download ❌ introspection tests🔥 Failed catastrophically on VSTS: simulator tests - introspection (no summary found). Html Report (VSDrops) Download ❌ linker tests🔥 Failed catastrophically on VSTS: simulator tests - linker (no summary found). Html Report (VSDrops) Download ❌ mac_binding_project tests🔥 Failed catastrophically on VSTS: simulator tests - mac_binding_project (no summary found). Html Report (VSDrops) Download ❌ mmp tests🔥 Failed catastrophically on VSTS: simulator tests - mmp (no summary found). Html Report (VSDrops) Download ❌ mononative tests🔥 Failed catastrophically on VSTS: simulator tests - mononative (no summary found). Html Report (VSDrops) Download ❌ monotouch tests🔥 Failed catastrophically on VSTS: simulator tests - monotouch (no summary found). Html Report (VSDrops) Download ❌ msbuild tests🔥 Failed catastrophically on VSTS: simulator tests - msbuild (no summary found). Html Report (VSDrops) Download ❌ mtouch tests🔥 Failed catastrophically on VSTS: simulator tests - mtouch (no summary found). Html Report (VSDrops) Download ❌ xammac tests🔥 Failed catastrophically on VSTS: simulator tests - xammac (no summary found). Html Report (VSDrops) Download ❌ xcframework tests🔥 Failed catastrophically on VSTS: simulator tests - xcframework (no summary found). Html Report (VSDrops) Download ❌ xtro tests🔥 Failed catastrophically on VSTS: simulator tests - xtro (no summary found). Html Report (VSDrops) Download SuccessesPipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌No test package could be found for tests on macOS M1 - Mac Big Sur (11.5) Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 159 tests passed. Failures❌ msbuild tests [attempt 2]
Html Report (VSDrops) Download Successes✅ bcl: All 59 tests passed. [attempt 2] Html Report (VSDrops) Download Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 159 tests passed. Failures❌ msbuild tests [attempt 3]
Html Report (VSDrops) Download Successes✅ bcl: All 59 tests passed. [attempt 2] Html Report (VSDrops) Download Pipeline on Agent |
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2620). |
From net7, the original ILLInk targets are adding a new link attribute pointing to a supressions file inside the ILLink tasks folder, e.g: '--link-attributes "C:\Program Files\dotnet\sdk\7.0.100-rc.2.22477.23\Sdks\Microsoft.NET.ILLink.Tasks\build\6.0_suppressions.xml"'.
For remote builds, we need to replace the original dotnet folder with the XMA dotnet folder in the Mac, so in our override targets we replace this value before passing it to the ILLink task
Backport of #16294.