[release/6.0.4xx-xcode14] [illink] Ensure we replace the dotnet SDK path in the _ExtraTrimmerArgs for remote builds #16295
Conversation
…gs for remote builds From net7, the original ILLInk targets are adding a new link attribute pointing to a supressions file inside the ILLink tasks folder, e.g: '--link-attributes "C:\Program Files\dotnet\sdk\7.0.100-rc.2.22477.23\Sdks\Microsoft.NET.ILLink.Tasks\build\6.0_suppressions.xml"'. For remote builds, we need to replace the original dotnet folder with the XMA dotnet folder in the Mac, so in our override targets we replace this value before passing it to the ILLink task
vs-mobiletools-engineering-service2
requested review from
emaf,
mauroa,
rolfbjarne and
chamons
as code owners
vs-mobiletools-engineering-service2
added
backported
not-notes-worthy
|
🔥 Failed to compare API and create generator diff 🔥 Error: 'make' failed for the hash fe3d332. Pipeline on Agent |
❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌No test package could be found for tests on macOS Mac Catalina (10.15) Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌No test package could be found for tests on macOS M1 - Mac Big Sur (11.5) Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 159 tests passed. Failures❌ cecil tests
Html Report (VSDrops) Download Successes✅ bcl: All 59 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2620). |
rolfbjarne
changed the title
.gs for remote builds
From net7, the original ILLInk targets are adding a new link attribute pointing to a supressions file inside the ILLink tasks folder, e.g: '--link-attributes "C:\Program Files\dotnet\sdk\7.0.100-rc.2.22477.23\Sdks\Microsoft.NET.ILLink.Tasks\build\6.0_suppressions.xml"'.
For remote builds, we need to replace the original dotnet folder with the XMA dotnet folder in the Mac, so in our override targets we replace this value before passing it to the ILLink task
Backport of #16294