Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix manifest MSI versions for RC 1 #16090

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Sep 22, 2022

Context: https://github.com/xamarin/yaml-templates/pull/201
Fixes: dotnet/maui#10234

Some of the baseline manifest MSIs have a higher version than the latest RC 1 candidate that we shipped. This is causing upgrade issues when a standalone .NET 7.0.100 RC 1 SDK is installed before VS 17.4 preview 2.1.

Here is the full list of MSIs versions:

Product Baseline Released
iOS 127.187.47038 121.23.48581
MacCatalyst 127.187.47038 121.23.48581
tvOS 127.187.47038 121.23.48581
macOS 111.251.47038 112.215.48581

Fix future RC 1 versions by adding the commit distance to the baseline manifest MSI version, ensuring that manifest versions for newer commits always increment appropriately.

Context: xamarin/yaml-templates#201

Some of the baseline manifest MSIs have a higher version than the latest
RC 1 candidate that we shipped.  This is causing upgrade issues when a
standalone .NET 7.0.100 RC 1 SDK is installed before VS 17.4 preview 2.1.

Here is the full list of MSIs with problematic versions:

| Product     | Baseline      | Released     |
| ----------- | ------------- | ------------ |
| iOS         | 127.187.47038 | 121.23.48581 |
| MacCatalyst | 127.187.47038 | 121.23.48581 |
| tvOS        | 127.187.47038 | 121.23.48581 |

Fix future RC 1 releases by adding the commit distance to the baseline
manifest MSI version, ensuring that manifest versions for newer commits
always increment appropriately.
@pjcollins
Copy link
Member Author

We should be able to check the vs-workload.props file that is uploaded to build artifacts to confirm that this is working as expected.

@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Sep 22, 2022
@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1044.Monterey'
Hash: 962d09abf9977257d0edafd2c1d8d8e7c30fa1c5 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 962d09abf9977257d0edafd2c1d8d8e7c30fa1c5 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Failed to compare API and create generator diff 🔥

Failed to update apidiff references

Pipeline on Agent
Hash: 962d09abf9977257d0edafd2c1d8d8e7c30fa1c5 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • introspection
  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: 962d09abf9977257d0edafd2c1d8d8e7c30fa1c5 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ mmp tests

1 tests failed, 1 tests passed.
  • mmptest/macOS/Debug: Failed (Execution failed with exit code 2)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne
Copy link
Member

Test failures are unrelated (https://github.com/xamarin/maccore/issues/2612).

@rolfbjarne rolfbjarne merged commit 36bea03 into release/7.0.1xx-rc1 Sep 23, 2022
@rolfbjarne rolfbjarne deleted the fix-rc1-msi branch September 23, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants