-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Fix manifest MSI versions for RC 1 #16090
Conversation
Context: xamarin/yaml-templates#201 Some of the baseline manifest MSIs have a higher version than the latest RC 1 candidate that we shipped. This is causing upgrade issues when a standalone .NET 7.0.100 RC 1 SDK is installed before VS 17.4 preview 2.1. Here is the full list of MSIs with problematic versions: | Product | Baseline | Released | | ----------- | ------------- | ------------ | | iOS | 127.187.47038 | 121.23.48581 | | MacCatalyst | 127.187.47038 | 121.23.48581 | | tvOS | 127.187.47038 | 121.23.48581 | Fix future RC 1 releases by adding the commit distance to the baseline manifest MSI version, ensuring that manifest versions for newer commits always increment appropriately.
We should be able to check the vs-workload.props file that is uploaded to build artifacts to confirm that this is working as expected. |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
🔥 Failed to compare API and create generator diff 🔥 Failed to update apidiff references Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 222 tests passed. Failures❌ mmp tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2612). |
Context: https://github.com/xamarin/yaml-templates/pull/201
Fixes: dotnet/maui#10234
Some of the baseline manifest MSIs have a higher version than the latest RC 1 candidate that we shipped. This is causing upgrade issues when a standalone .NET 7.0.100 RC 1 SDK is installed before VS 17.4 preview 2.1.
Here is the full list of MSIs versions:
Fix future RC 1 versions by adding the commit distance to the baseline manifest MSI version, ensuring that manifest versions for newer commits always increment appropriately.