Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0.1xx-xcode14-rc2] [mtouch] Automatically disable bitcode if using Xcode 14+. Fixes #15210. #16053

Conversation

vs-mobiletools-engineering-service2
Copy link
Collaborator

Apple has deprecated bitcode, and will apparently reject app submissions
containing bitcode starting with Xcode 14. So automatically disable bitcode if
building using Xcode 14+ (and show a warning so that app developers can remove
the 'MtouchEnableBitcode' property from their project files).

Fixes #15210.

Backport of #15804

…et#15210.

Apple has deprecated bitcode, and will apparently reject app submissions
containing bitcode starting with Xcode 14. So automatically disable bitcode if
building using Xcode 14+ (and show a warning so that app developers can remove
the 'MtouchEnableBitcode' property from their project files).

Fixes dotnet#15210.
watchOS will now compile for bitcode + native code, then remove bitcode, since
the AOT compiler doesn't like building just native code.
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

No test package could be found for tests on macOS M1 - Mac Big Sur (11.5)

Pipeline on Agent
Hash: 91555c00481131e9ba1443df0b269ff579664e0c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

🔥 Failed to compare API and create generator diff 🔥

Failed to update apidiff references

Pipeline on Agent
Hash: 91555c00481131e9ba1443df0b269ff579664e0c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 159 tests passed.

Failures

❌ monotouch tests

1 tests failed, 19 tests passed.
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): TimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 59 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 5 tests passed. Html Report (VSDrops) Download
✅ framework: All 5 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 5 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 5 tests passed. Html Report (VSDrops) Download
✅ linker: All 38 tests passed. Html Report (VSDrops) Download
⚠️ mac_binding_project: No tests selected. Html Report (VSDrops) Download
⚠️ mmp: No tests selected. Html Report (VSDrops) Download
✅ mononative: All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
⚠️ xammac: No tests selected. Html Report (VSDrops) Download
✅ xcframework: All 5 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne
Copy link
Member

Test failure is unrelated (https://github.com/xamarin/maccore/issues/581).

@rolfbjarne rolfbjarne merged commit c5c7f00 into dotnet:release/7.0.1xx-xcode14-rc2 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported do-not-merge Do not merge this pull request notes-mention Deserves a mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants