Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msbuild] Compute _AppContainerDir from AppBundleDir if AppBundleDir is set by the developer. Fixes #15014. #15869

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

rolfbjarne
Copy link
Member

Fixes #15014.

@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Sep 5, 2022
@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent XAMBOT-1161.Monterey'
Hash: 5051db41cb51a93312f8ec67582788785e8ed79e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 5051db41cb51a93312f8ec67582788785e8ed79e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 5051db41cb51a93312f8ec67582788785e8ed79e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Tests timed out

Pipeline on Agent
Hash: 5051db41cb51a93312f8ec67582788785e8ed79e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 13 tests failed, 210 tests passed.

Failures

❌ linker tests

13 tests failed, 52 tests passed.
  • dont link/tvOS - simulator/Debug [dotnet]: LaunchTimedOut
  • dont link/tvOS - simulator/Release [dotnet]: LaunchTimedOut
  • dont link/tvOS - simulator/Debug: LaunchTimedOut
  • dont link/tvOS - simulator/Release: LaunchTimedOut
  • link sdk/tvOS - simulator/Debug [dotnet]: LaunchTimedOut
  • link sdk/tvOS - simulator/Release [dotnet]: LaunchTimedOut
  • link all/tvOS - simulator/Debug [dotnet]: LaunchTimedOut
  • link all/tvOS - simulator/Release [dotnet]: LaunchTimedOut
  • link all/tvOS - simulator/Debug: LaunchTimedOut
  • trimmode copy/tvOS - simulator/Debug [dotnet]: LaunchTimedOut
  • trimmode copy/tvOS - simulator/Release [dotnet]: LaunchTimedOut
  • trimmode link/tvOS - simulator/Debug [dotnet]: LaunchTimedOut
  • trimmode link/tvOS - simulator/Release [dotnet]: LaunchTimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne
Copy link
Member Author

Test failures are unrelated (https://github.com/xamarin/maccore/issues/2450)

@rolfbjarne rolfbjarne marked this pull request as ready for review September 6, 2022 07:01
@rolfbjarne rolfbjarne merged commit 62bc027 into dotnet:main Sep 7, 2022
@rolfbjarne rolfbjarne deleted the issue-15014 branch September 7, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug If an issue is a bug or a pull request a bug fix
Projects
None yet
5 participants