Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add support to net6.0 for multi-targeting in VS #15776

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Aug 25, 2022

Context: https://github.com/xamarin/yaml-templates/pull/180
Context: https://github.com/xamarin/yaml-templates/pull/195
Context: https://github.com/xamarin/yaml-templates/pull/199
Context: #15761

Updates the build to use the latest MSI generation template. The v3
template uses the latest changes from arcade which include a large
refactoring, support for multi-targeting, and support for workload pack
group MSIs.

The build will now produce two different VS Drop artifacts. The MSI and
VSMAN files generated for SDK packs have been split out into a new
vsdrop-multitarget-signed artifact, allowing us to include multiple
versions of the SDK packs in VS.

All of the SDK packs have been renamed to include a .net6 suffix to
match the pack aliases that will be referenced in the .NET 7 manifests.

Context: xamarin/yaml-templates#180
Context: xamarin/yaml-templates#195
Context: xamarin/yaml-templates#199
Context: #15469

Updates the build to use the latest MSI generation template. The v3
template uses the latest changes from arcade which include a large
refactoring, support for multi-targeting, and support for workload pack
group MSIs.

The build will now produce two different VS Drop artifacts.  The MSI and
VSMAN files generated for SDK packs have been split out into a new
`vsdrop-multitarget-signed` artifact, allowing us to include multiple
versions of the SDK packs in VS.

All of the SDK packs have been renamed to include a `.net6` suffix to
match the pack aliases that will be referenced in the .NET 7 manifests.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

📋 [PR Build] API Diff 📋

API Current PR diff

✅ API Diff (from PR only) (no change)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

Generator Diff (no change)

Pipeline on Agent XAMBOT-1037.Monterey'
Hash: 3fb543ffab10e15e33cdd6997a817f553775b979

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1198.Monterey'
Hash: 3fb543ffab10e15e33cdd6997a817f553775b979

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 3fb543ffab10e15e33cdd6997a817f553775b979

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • introspection
  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: 3fb543ffab10e15e33cdd6997a817f553775b979

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

🎉 All 146 tests passed 🎉

Pipeline on Agent XAMBOT-1094.Monterey
Merge 3fb543f into 84e86f5

@rolfbjarne
Copy link
Member

This should probably go in main too.

@pjcollins
Copy link
Member Author

Looking at #15761 I believe I have all of the required SDK packs renamed here, I think this should be good to go.

I'll put up a PR for net7.0/main shortly.

@pjcollins pjcollins marked this pull request as ready for review August 26, 2022 15:02
@rolfbjarne
Copy link
Member

@pjcollins you can probably piggy-back on this PR for net7.0: #15785

@rolfbjarne rolfbjarne merged commit 8bb8e22 into release/6.0.4xx Aug 26, 2022
@rolfbjarne rolfbjarne deleted the multidrop6 branch August 26, 2022 15:05
@pjcollins
Copy link
Member Author

/sudo backport main

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch main Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6612480 for more details.

rolfbjarne pushed a commit that referenced this pull request Aug 29, 2022
Context: xamarin/yaml-templates#180
Context: xamarin/yaml-templates#195
Context: xamarin/yaml-templates#199
Context: #15761

Updates the build to use the latest MSI generation template. The v3
template uses the latest changes from arcade which include a large
refactoring, support for multi-targeting, and support for workload pack
group MSIs.

The build will now produce two different VS Drop artifacts.  The MSI and
VSMAN files generated for SDK packs have been split out into a new
`vsdrop-multitarget-signed` artifact, allowing us to include multiple
versions of the SDK packs in VS.

All of the SDK packs have been renamed to include a `.net6` suffix to
match the pack aliases that will be referenced in the .NET 7 manifests.


Backport of #15776

Co-authored-by: Peter Collins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants