[.NET/CoreMidi] Use [UnmanagedCallersOnly] instead of [MonoPInvokeCallback] Partial Fix for #10470 #15774

stephen-hawley · 2022-08-25T15:34:38Z

rolfbjarne

Looks good otherwise!

rolfbjarne · 2022-08-25T16:15:36Z

src/CoreMidi/MidiServices.cs

@@ -936,7 +960,7 @@ internal unsafe static IntPtr CreatePacketList (MidiPacket [] packets)
 	[SupportedOSPlatform ("maccatalyst")]
 	[SupportedOSPlatform ("macos")]
 #endif
-	public class MidiPort : MidiObject {
+	public unsafe class MidiPort : MidiObject {


In general we try to make the unsafe scope as small as possible, so:

Mark the P/Invoke as unsafe

Add an unsafe {} block around the call to the P/Invoke.

rolfbjarne · 2022-08-26T11:07:33Z

src/CoreMidi/MidiServices.cs

@@ -2095,7 +2146,7 @@ internal override void DisposeHandle ()
 	[SupportedOSPlatform ("maccatalyst")]
 	[SupportedOSPlatform ("macos")]
 #endif
-	public class MidiEndpoint : MidiObject {
+	public unsafe class MidiEndpoint : MidiObject {


dalexsoto

👍 After last Rolf's comment is addressed.

vs-mobiletools-engineering-service2 · 2022-08-26T13:50:17Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 41 tests failed, 4291 tests passed.

Failures

❌ bcl tests

2 tests failed, 226 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)
mmptest/macOS/Debug: Failed (Execution failed with exit code 2)

Html Report (VSDrops) Download

❌ cecil tests

1 tests failed, 227 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ dotnettests tests

1 tests failed, 227 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ fsharp tests

1 tests failed, 227 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ framework tests

1 tests failed, 227 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ generator tests

1 tests failed, 227 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ interdependent_binding_projects tests

2 tests failed, 226 tests passed.

trimmode link/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut ( (failed to parse the logs: The Writer is closed or in error state.))
introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ install_source tests

1 tests failed, 227 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 227 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ linker tests

1 tests failed, 227 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ mac_binding_project tests

14 tests failed, 214 tests passed.

monotouch-test/Mac [dotnet]/Debug [dotnet]: BuildFailure (Harness exception for 'monotouch-test': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/2/s/xamarin-macios/tests/fsharplibrary/dotnet/macOS (TimedOut: True ExitCode: 0):
Running git ls-files
Makefile
fsharplibrary.fsproj
Process 93530 didn't exit within 00:01:00 and will be killed
Killing process tree of 93530...
Pids to kill: 93530
Running lldb diagnostics for pid 93530
Printing backtrace for pid=93530
(lldb) command source -s 0 '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp695caa4a.tmp'
Executing commands in '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp695caa4a.tmp'.
(lldb) process attach --pid 93530
error: attach failed: no such process.
93530 Execution timed out after 60 seconds and the process was killed.
Process git exited with 0
at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:103
at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:208
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )
monotouch-test/Mac [dotnet]/Debug (static registrar) [dotnet]: BuildFailure (Harness exception for 'monotouch-test': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/2/s/xamarin-macios/tests/fsharplibrary/dotnet/macOS (TimedOut: True ExitCode: 0):
Running git ls-files
Makefile
fsharplibrary.fsproj
Process 93530 didn't exit within 00:01:00 and will be killed
Killing process tree of 93530...
Pids to kill: 93530
Running lldb diagnostics for pid 93530
Printing backtrace for pid=93530
(lldb) command source -s 0 '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp695caa4a.tmp'
Executing commands in '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp695caa4a.tmp'.
(lldb) process attach --pid 93530
error: attach failed: no such process.
93530 Execution timed out after 60 seconds and the process was killed.
Process git exited with 0
at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:103
at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:208
at Xharness.Jenkins.TestVariationsFactory+<>c__DisplayClass4_2`1[T].b__0 () [0x00044] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestVariationsFactory.cs:216
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )
monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure (Harness exception for 'monotouch-test': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/2/s/xamarin-macios/tests/fsharplibrary/dotnet/MacCatalyst (TimedOut: True ExitCode: 0):
Running git ls-files
Makefile
fsharplibrary.fsproj
Process 93531 didn't exit within 00:01:00 and will be killed
Killing process tree of 93531...
Pids to kill: 93531
Running lldb diagnostics for pid 93531
Printing backtrace for pid=93531
(lldb) command source -s 0 '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp187b8317.tmp'
Executing commands in '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp187b8317.tmp'.
(lldb) process attach --pid 93531
error: attach failed: no such process.
93531 Execution timed out after 60 seconds and the process was killed.
Process git exited with 0
at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:103
at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:208
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )
monotouch-test/iOS Unified 64-bits - simulator/Debug [dotnet]: BuildFailure (Harness exception for 'monotouch-test': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/2/s/xamarin-macios/tests/fsharplibrary/dotnet/iOS (TimedOut: True ExitCode: 0):
Running git ls-files
Makefile
fsharplibrary.fsproj
Process 93526 didn't exit within 00:01:00 and will be killed
Killing process tree of 93526...
Pids to kill: 93526
Running lldb diagnostics for pid 93526
Printing backtrace for pid=93526
(lldb) command source -s 0 '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b157ce9.tmp'
Executing commands in '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b157ce9.tmp'.
(lldb) process attach --pid 93526
error: attach failed: no such process.
93526 Execution timed out after 60 seconds and the process was killed.
Process git exited with 0
at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:103
at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:208
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )
monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk) [dotnet]: BuildFailure (Harness exception for 'monotouch-test': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/2/s/xamarin-macios/tests/fsharplibrary/dotnet/iOS (TimedOut: True ExitCode: 0):
Running git ls-files
Makefile
fsharplibrary.fsproj
Process 93526 didn't exit within 00:01:00 and will be killed
Killing process tree of 93526...
Pids to kill: 93526
Running lldb diagnostics for pid 93526
Printing backtrace for pid=93526
(lldb) command source -s 0 '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b157ce9.tmp'
Executing commands in '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b157ce9.tmp'.
(lldb) process attach --pid 93526
error: attach failed: no such process.
93526 Execution timed out after 60 seconds and the process was killed.
Process git exited with 0
at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:103
at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:208
at Xharness.Jenkins.TestVariationsFactory+<>c__DisplayClass4_2`1[T].b__0 () [0x00044] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestVariationsFactory.cs:216
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar) [dotnet]: BuildFailure (Harness exception for 'monotouch-test': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/2/s/xamarin-macios/tests/fsharplibrary/dotnet/iOS (TimedOut: True ExitCode: 0):
Running git ls-files
Makefile
fsharplibrary.fsproj
Process 93526 didn't exit within 00:01:00 and will be killed
Killing process tree of 93526...
Pids to kill: 93526
Running lldb diagnostics for pid 93526
Printing backtrace for pid=93526
(lldb) command source -s 0 '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b157ce9.tmp'
Executing commands in '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b157ce9.tmp'.
(lldb) process attach --pid 93526
error: attach failed: no such process.
93526 Execution timed out after 60 seconds and the process was killed.
Process git exited with 0
at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:103
at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:208
at Xharness.Jenkins.TestVariationsFactory+<>c__DisplayClass4_2`1[T].b__0 () [0x00044] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestVariationsFactory.cs:216
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )
monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations) [dotnet]: BuildFailure (Harness exception for 'monotouch-test': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/2/s/xamarin-macios/tests/fsharplibrary/dotnet/iOS (TimedOut: True ExitCode: 0):
Running git ls-files
Makefile
fsharplibrary.fsproj
Process 93526 didn't exit within 00:01:00 and will be killed
Killing process tree of 93526...
Pids to kill: 93526
Running lldb diagnostics for pid 93526
Printing backtrace for pid=93526
(lldb) command source -s 0 '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b157ce9.tmp'
Executing commands in '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b157ce9.tmp'.
(lldb) process attach --pid 93526
error: attach failed: no such process.
93526 Execution timed out after 60 seconds and the process was killed.
Process git exited with 0
at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:103
at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:208
at Xharness.Jenkins.TestVariationsFactory+<>c__DisplayClass4_2`1[T].b__0 () [0x00044] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestVariationsFactory.cs:216
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )
monotouch-test/tvOS - simulator/Debug [dotnet]: BuildFailure (Harness exception for 'monotouch-test': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/2/s/xamarin-macios/tests/fsharplibrary/dotnet/tvOS (TimedOut: True ExitCode: 0):
Running git ls-files
Makefile
fsharplibrary.fsproj
Process 93527 didn't exit within 00:01:00 and will be killed
Killing process tree of 93527...
Pids to kill: 93527
Running lldb diagnostics for pid 93527
Printing backtrace for pid=93527
(lldb) command source -s 0 '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b3238d4.tmp'
Executing commands in '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b3238d4.tmp'.
(lldb) process attach --pid 93527
error: attach failed: no such process.
93527 Execution timed out after 60 seconds and the process was killed.
Process git exited with 0
at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:103
at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:208
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )
monotouch-test/tvOS - simulator/Debug (LinkSdk) [dotnet]: BuildFailure (Harness exception for 'monotouch-test': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/2/s/xamarin-macios/tests/fsharplibrary/dotnet/tvOS (TimedOut: True ExitCode: 0):
Running git ls-files
Makefile
fsharplibrary.fsproj
Process 93527 didn't exit within 00:01:00 and will be killed
Killing process tree of 93527...
Pids to kill: 93527
Running lldb diagnostics for pid 93527
Printing backtrace for pid=93527
(lldb) command source -s 0 '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b3238d4.tmp'
Executing commands in '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b3238d4.tmp'.
(lldb) process attach --pid 93527
error: attach failed: no such process.
93527 Execution timed out after 60 seconds and the process was killed.
Process git exited with 0
at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:103
at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:208
at Xharness.Jenkins.TestVariationsFactory+<>c__DisplayClass4_2`1[T].b__0 () [0x00044] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestVariationsFactory.cs:216
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )
monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: BuildFailure (Harness exception for 'monotouch-test': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/2/s/xamarin-macios/tests/fsharplibrary/dotnet/tvOS (TimedOut: True ExitCode: 0):
Running git ls-files
Makefile
fsharplibrary.fsproj
Process 93527 didn't exit within 00:01:00 and will be killed
Killing process tree of 93527...
Pids to kill: 93527
Running lldb diagnostics for pid 93527
Printing backtrace for pid=93527
(lldb) command source -s 0 '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b3238d4.tmp'
Executing commands in '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b3238d4.tmp'.
(lldb) process attach --pid 93527
error: attach failed: no such process.
93527 Execution timed out after 60 seconds and the process was killed.
Process git exited with 0
at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:103
at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:208
at Xharness.Jenkins.TestVariationsFactory+<>c__DisplayClass4_2`1[T].b__0 () [0x00044] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestVariationsFactory.cs:216
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )
monotouch-test/tvOS - simulator/Release (all optimizations) [dotnet]: BuildFailure (Harness exception for 'monotouch-test': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/2/s/xamarin-macios/tests/fsharplibrary/dotnet/tvOS (TimedOut: True ExitCode: 0):
Running git ls-files
Makefile
fsharplibrary.fsproj
Process 93527 didn't exit within 00:01:00 and will be killed
Killing process tree of 93527...
Pids to kill: 93527
Running lldb diagnostics for pid 93527
Printing backtrace for pid=93527
(lldb) command source -s 0 '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b3238d4.tmp'
Executing commands in '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp5b3238d4.tmp'.
(lldb) process attach --pid 93527
error: attach failed: no such process.
93527 Execution timed out after 60 seconds and the process was killed.
Process git exited with 0
at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:103
at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:208
at Xharness.Jenkins.TestVariationsFactory+<>c__DisplayClass4_2`1[T].b__0 () [0x00044] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestVariationsFactory.cs:216
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )
introspection/iOS Unified 64-bits - simulator/Debug (iOS 12.4) [dotnet]: BuildFailure (Harness exception for 'introspection': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/tmp-test-dir/introspection3304 (TimedOut: True ExitCode: 0):
Running git ls-files
Process 93528 didn't exit within 00:01:00 and will be killed
Killing process tree of 93528...
Pids to kill: 93528
Running lldb diagnostics for pid 93528
Printing backtrace for pid=93528
(lldb) command source -s 0 '/var/folders/9p/8dc60h8s6355j6y3qr7cgzth0000gn/T/tmp1e92a5f9.tmp'
Executing commands in '/va\n\nThe message from CI is too large for the GitHub comments. You can find the full results here.

vs-mobiletools-engineering-service2 · 2022-08-26T17:26:50Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: a22f38527a72d2b9d8e4f6ceb341f8239d63a204 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-26T17:31:00Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-014.Monterey'
Hash: a22f38527a72d2b9d8e4f6ceb341f8239d63a204 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-26T17:32:57Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: a22f38527a72d2b9d8e4f6ceb341f8239d63a204 [PR build]

vs-mobiletools-engineering-service2 · 2022-08-26T17:57:40Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

introspection
xammac_tests
monotouch-test

Pipeline on Agent
Hash: a22f38527a72d2b9d8e4f6ceb341f8239d63a204 [PR build]

net 7 updates for pinvokes in CoreMidi

54a448c

stephen-hawley added run-all-tests Run all our tests. skip-device-tests Skip device tests not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Aug 25, 2022

rolfbjarne approved these changes Aug 25, 2022

View reviewed changes

narrow up unsafe scope

a562c04

This comment has been minimized.

Sign in to view

rolfbjarne reviewed Aug 26, 2022

View reviewed changes

dalexsoto approved these changes Aug 26, 2022

View reviewed changes

more scope narrowing

a22f385

rolfbjarne approved these changes Aug 26, 2022

View reviewed changes

stephen-hawley merged commit 9a40048 into dotnet:main Aug 26, 2022

stephen-hawley deleted the pinvoke-coremidi branch August 26, 2022 20:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[.NET/CoreMidi] Use [UnmanagedCallersOnly] instead of [MonoPInvokeCallback] Partial Fix for #10470 #15774

[.NET/CoreMidi] Use [UnmanagedCallersOnly] instead of [MonoPInvokeCallback] Partial Fix for #10470 #15774

stephen-hawley commented Aug 25, 2022 •

edited by rolfbjarne

Loading

rolfbjarne left a comment

rolfbjarne Aug 25, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Aug 26, 2022

dalexsoto left a comment

vs-mobiletools-engineering-service2 commented Aug 26, 2022

vs-mobiletools-engineering-service2 commented Aug 26, 2022

vs-mobiletools-engineering-service2 commented Aug 26, 2022

vs-mobiletools-engineering-service2 commented Aug 26, 2022

vs-mobiletools-engineering-service2 commented Aug 26, 2022

[.NET/CoreMidi] Use [UnmanagedCallersOnly] instead of [MonoPInvokeCallback] Partial Fix for #10470 #15774

[.NET/CoreMidi] Use [UnmanagedCallersOnly] instead of [MonoPInvokeCallback] Partial Fix for #10470 #15774

Conversation

stephen-hawley commented Aug 25, 2022 • edited by rolfbjarne Loading

rolfbjarne left a comment

Choose a reason for hiding this comment

rolfbjarne Aug 25, 2022

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Aug 26, 2022

Choose a reason for hiding this comment

dalexsoto left a comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Aug 26, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ bcl tests

❌ cecil tests

❌ dotnettests tests

❌ fsharp tests

❌ framework tests

❌ generator tests

❌ interdependent_binding_projects tests

❌ install_source tests

❌ introspection tests

❌ linker tests

❌ mac_binding_project tests

vs-mobiletools-engineering-service2 commented Aug 26, 2022

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

vs-mobiletools-engineering-service2 commented Aug 26, 2022

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Aug 26, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

vs-mobiletools-engineering-service2 commented Aug 26, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

stephen-hawley commented Aug 25, 2022 •

edited by rolfbjarne

Loading