[msbuild] Remove the Xamarin.*.Task.Core assemblies. #15768
Conversation
It's not needed anymore, and this speeds up and simplifies the build a bit.
Remove the Xamarin.MacDev.Tasks.Core assembly and move all the code into the Xamarin.MacDev.Tasks assembly.
| @@ -0,0 +1,9 @@ | |||
| extern alias Microsoft_Build_Tasks_Core; | |||
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Tests timed out Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
We used to do the following:
the actual code for the task in question to work properly on macOS).
Windows-specific overrides for the implementation in the abstract base
class.
However, we no longer do point 3, which means that we no longer need to split
our tasks across two assemblies.
This means that we can remove the Xamarin.*.Task.Core assemblies, and move all
the code into the corresponding Xamarin.*.Task assembly instead.
This simplifies our code and speeds up the build.
There are more simplifications that can be done; those will come in later PRs.