Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] macOS/MacCatalyst Archive and publishing support #15720

Merged
merged 3 commits into from
Aug 26, 2022
Merged

[dotnet] macOS/MacCatalyst Archive and publishing support #15720

merged 3 commits into from
Aug 26, 2022

Conversation

emaf
Copy link
Contributor

@emaf emaf commented Aug 22, 2022

These changes are required to support Archive and Publishing for .NET macOS/MacCatalyst projects from VS for Mac.

emaf added 2 commits August 18, 2022 18:14
@emaf
[msbuild] Fix Archive task to not require a SigningKey
11a2958 
macOS and MacCatalyst archives don't require a SigningKey so this parameter should not be required.
@emaf
[dotnet] Support creating installers from archives
2e1ee64 
By doing this we can reuse the `_CreateInstaller` target from the VS for Mac Archive and Publishing feature.

The main change here is when publishing from an archive, we don't have the entitlements used to sign the app originally, so we need to retrieve them from the app bundle in order to include them when resigning the app.
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@dalexsoto dalexsoto added the not-notes-worthy Ignore for release notes label Aug 25, 2022
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 3e26e89b0c2f7690f35e6e3d82a99f99ba165418 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1106.Monterey'
Hash: 3e26e89b0c2f7690f35e6e3d82a99f99ba165418 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 3e26e89b0c2f7690f35e6e3d82a99f99ba165418 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ mmp tests

1 tests failed, 1 tests passed.
  • mmptest/macOS/Debug: Failed (Execution failed with exit code 2)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne
Copy link
Member

Test failures are unrelated (https://github.com/xamarin/maccore/issues/2612).

@rolfbjarne rolfbjarne changed the title [dotnet] macOS/MacCatalyst Archive and publishing support [dotnet] macOS/MacCatalyst Archive and publishing support Aug 26, 2022
@rolfbjarne rolfbjarne merged commit b1a732d into main Aug 26, 2022
@rolfbjarne rolfbjarne deleted the dev/ema/publishing branch August 26, 2022 06:18
emaf added a commit that referenced this pull request Aug 29, 2022
@emaf @dalexsoto
[dotnet] macOS/MacCatalyst Archive and publishing support (#15720)
b273e0f 
These changes are required to support Archive and Publishing for .NET macOS/MacCatalyst projects from VS for Mac.

Co-authored-by: Alex Soto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@chamons chamons chamons approved these changes

@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emaf @vs-mobiletools-engineering-service2 @rolfbjarne @dalexsoto @chamons