[msbuild/tools] Fix path issues in the FilterStaticFrameworks task and ExtractBindingLibraries step. Fixes #15289. #15321
Conversation
…d ExtractBindingLibraries step. Fixes dotnet#15289. In the FilterStaticFrameworks task: * Convert Windows-style paths to Mac-style paths. * Give a better error if a framework can't be found. * Don't try to copy frameworks that don't exist on Windows to the Mac. In the ExtractBindingLibrariesStep: * Return a relative path to frameworks we've extracted to make things easier for remote builds. * In the _ComputeFrameworkFilesToPublish target, don't compute the source directory for frameworks using RootDir + Directory, because some frameworks may only exist on the mac, and RootDir + Directory will be a Windows path when building remotely. Instead use 'Identity', which is a relative path and will work on both Windows and Mac. Fixes dotnet#15289.
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results9 tests failed, 139 tests passed.Failed tests
Pipeline on Agent XAMBOT-1105.Monterey' |
🔥 [PR Build] Build failed 🔥Build failed for the job 'Detect API changes' Pipeline on Agent |
|
🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 4 tests failed, 219 tests passed. Failures❌ monotouch tests
Html Report (VSDrops) Download ❌ mtouch tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
Test failures are unrelated:
|
|
/sudo backport d17-2 |
|
/sudo backport release/6.0.3xx |
|
/sudo backport release/6.0.4xx |
|
Backport Job to branch d17-2 Created! The magic is happening here |
|
Backport Job to branch release/6.0.3xx Created! The magic is happening here |
|
Backport Job to branch release/6.0.4xx Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6395065 for more details. |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6395064 for more details. |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6395066 for more details. |
…Frameworks task and ExtractBindingLibraries step. Fixes #15289. (#15442) In the FilterStaticFrameworks task: * Convert Windows-style paths to Mac-style paths. * Give a better error if a framework can't be found. * Don't try to copy frameworks that don't exist on Windows to the Mac. In the ExtractBindingLibrariesStep: * Return a relative path to frameworks we've extracted to make things easier for remote builds. * In the _ComputeFrameworkFilesToPublish target, don't compute the source directory for frameworks using RootDir + Directory, because some frameworks may only exist on the mac, and RootDir + Directory will be a Windows path when building remotely. Instead use 'Identity', which is a relative path and will work on both Windows and Mac. Fixes #15289. Backport of #15321 Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
…Frameworks task and ExtractBindingLibraries step. Fixes #15289. (#15444) In the FilterStaticFrameworks task: * Convert Windows-style paths to Mac-style paths. * Give a better error if a framework can't be found. * Don't try to copy frameworks that don't exist on Windows to the Mac. In the ExtractBindingLibrariesStep: * Return a relative path to frameworks we've extracted to make things easier for remote builds. * In the _ComputeFrameworkFilesToPublish target, don't compute the source directory for frameworks using RootDir + Directory, because some frameworks may only exist on the mac, and RootDir + Directory will be a Windows path when building remotely. Instead use 'Identity', which is a relative path and will work on both Windows and Mac. Fixes #15289. Backport of #15321 Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
|
Has this fix merged into Xamarin or net6.0-ios? |
|
This has been merged into 6.0.4 release branch, currently available in 17.3 Preview 6, and will be in the next stable release. |
|
I still have the problem with 17.3.0 Preview 6. |
|
I can confirm @dominic7125 report. I have a same trouble on last version of Microsoft Visual Studio Enterprise 2022 (64-bit) - Preview Version 17.4.0 Preview 1.0 MAUI/Net6 and IOS binding of native framework. Exactly same as dotnet/maui#8000
Any workaround or solution ? It is blocker for us to migrate from Forms to MAUI. |
|
@LukasKuchta please file a new issue (https://github.com/xamarin/xamarin-macios/issues/new) and attach a binlog and we'll have a look. |
|
@LukasKuchta |
In the FilterStaticFrameworks task:
In the ExtractBindingLibrariesStep:
Return a relative path to frameworks we've extracted to make things easier for
remote builds.
In the _ComputeFrameworkFilesToPublish target, don't compute the source
directory for frameworks using RootDir + Directory, because some frameworks
may only exist on the mac, and RootDir + Directory will be a Windows path
when building remotely. Instead use 'Identity', which is a relative path and
will work on both Windows and Mac.
Fixes #15289.