-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[imagecapturecore] Add nullability to (generated and manual) bindings #15127
[imagecapturecore] Add nullability to (generated and manual) bindings #15127
Conversation
@@ -495,7 +495,7 @@ interface IICCameraDeviceDownloadDelegate {} | |||
interface ICCameraDeviceDownloadDelegate { | |||
|
|||
[Export ("didDownloadFile:error:options:contextInfo:")] | |||
void DidDownloadFile (ICCameraFile file, [NullAllowed] NSError error, [NullAllowed] NSDictionary<NSString, NSObject> options, [NullAllowed] IntPtr contextInfo); | |||
void DidDownloadFile (ICCameraFile file, [NullAllowed] NSError error, NSDictionary<NSString, NSObject> options, [NullAllowed] IntPtr contextInfo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change and the two below remove a NullAllowed on NSDictionary parameters. The headers and docs both agree that these are not nullable - but wanted to make sure that removing these wouldn't be a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this is a breaking change, though it could in theory break a build if:
- They have null allowed warnings on
- They have warnings as error enabled
- They were passing in null to this param.
But I'm fine with that I think.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
📋 [PR Build] API Diff 📋API diff (for current PR)ℹ️ API Diff (from PR only) (please review changes) .NETXamarin vs .NETAPI diff (vs stable)✅ API Diff from stable .NETXamarin vs .NETGenerator diffℹ️ Generator Diff (please review changes) Pipeline on Agent XAMBOT-1099.Monterey' |
Unrelated Test Failures: https://github.com/xamarin/maccore/issues/2558 |
This PR aims to bring nullability changes to ImageCaptureCore.
Following the steps here:
!missing-null-allowed!
in this frameworks ignore files and applying them