Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imagecapturecore] Add nullability to (generated and manual) bindings #15127

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

tj-devel709
Copy link
Member

This PR aims to bring nullability changes to ImageCaptureCore.
Following the steps here:

  1. I am looking for any !missing-null-allowed! in this frameworks ignore files and applying them

@tj-devel709 tj-devel709 added the not-notes-worthy Ignore for release notes label May 26, 2022
@tj-devel709 tj-devel709 added this to the Future milestone May 26, 2022
@@ -495,7 +495,7 @@ interface IICCameraDeviceDownloadDelegate {}
interface ICCameraDeviceDownloadDelegate {

[Export ("didDownloadFile:error:options:contextInfo:")]
void DidDownloadFile (ICCameraFile file, [NullAllowed] NSError error, [NullAllowed] NSDictionary<NSString, NSObject> options, [NullAllowed] IntPtr contextInfo);
void DidDownloadFile (ICCameraFile file, [NullAllowed] NSError error, NSDictionary<NSString, NSObject> options, [NullAllowed] IntPtr contextInfo);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change and the two below remove a NullAllowed on NSDictionary parameters. The headers and docs both agree that these are not nullable - but wanted to make sure that removing these wouldn't be a breaking change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this is a breaking change, though it could in theory break a build if:

  • They have null allowed warnings on
  • They have warnings as error enabled
  • They were passing in null to this param.

But I'm fine with that I think.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 99c08290d48fb612bb1d5a602625d7c4cc85f23d

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1097.Monterey'
Hash: 99c08290d48fb612bb1d5a602625d7c4cc85f23d

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📋 [PR Build] API Diff 📋

API diff (for current PR)

ℹ️ API Diff (from PR only) (please review changes)

API diff: vsdrops gist

Xamarin
.NET
Xamarin vs .NET
iOS vs Mac Catalyst (.NET)

API diff (vs stable)

✅ API Diff from stable

API diff: vsdrops gist

Xamarin
.NET
Xamarin vs .NET
iOS vs Mac Catalyst (.NET)

Generator diff

ℹ️ Generator Diff (please review changes)

Pipeline on Agent XAMBOT-1099.Monterey'
Hash: 99c08290d48fb612bb1d5a602625d7c4cc85f23d

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌

Tests failed on VSTS: simulator tests iOS.

Test results

1 tests failed, 147 tests passed.

Failed tests

  • fsharp/watchOS 32-bits - simulator/Debug: Crashed

Pipeline on Agent XAMBOT-1102.Monterey
Merge 99c0829 into 0307004

@tj-devel709
Copy link
Member Author

Unrelated Test Failures: https://github.com/xamarin/maccore/issues/2558

@tj-devel709 tj-devel709 merged commit f74d680 into dotnet:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants