Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with NSUrl implicit conversion and null #14860

Merged
merged 4 commits into from
May 6, 2022

Conversation

chamons
Copy link
Contributor

@chamons chamons commented Apr 29, 2022

Before fix test crashed with same:

System.NullReferenceException: Object reference not set to an instance of an object.
   at Foundation.NSUrl.op_Implicit(NSUrl url)

@chamons chamons added the notes-mention Deserves a mention in release notes label Apr 29, 2022
@chamons chamons requested a review from mandel-macaque as a code owner April 29, 2022 21:29
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Co-authored-by: Manuel de la Pena <[email protected]>
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@chamons chamons requested a review from mandel-macaque May 2, 2022 16:03
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a great opportunity to enable nullability in this file 😁

@mandel-macaque
Copy link
Member

@rolfbjarne that's a trap! :P

@chamons
Copy link
Contributor Author

chamons commented May 4, 2022

I'll take a stab.

@chamons chamons requested a review from tj-devel709 May 4, 2022 16:17
@chamons
Copy link
Contributor Author

chamons commented May 4, 2022

I added nullability as requested. @tj-devel709 please review my changes here.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1098.Monterey'
Hash: b7509d741e473cec1621ff8d2803125953dbd5fe

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: b7509d741e473cec1621ff8d2803125953dbd5fe

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: b7509d741e473cec1621ff8d2803125953dbd5fe

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [PR Build] Build failed 🔥

Build failed for the job 'Generate API diff'

Pipeline on Agent
Hash:

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

🎉 All 148 tests passed 🎉

Pipeline on Agent XAMBOT-1105.Monterey'
Merge b7509d7 into 01c3127

@chamons chamons merged commit 6a16226 into dotnet:main May 6, 2022
@chamons chamons deleted the issue_14786 branch May 6, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-mention Deserves a mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit conversion from NSUrl? to Uri? crashes on null value
5 participants