Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeAOT: Do not root the framework assembly #18779

Closed
Tracked by #18584
ivanpovazan opened this issue Aug 22, 2023 · 1 comment · Fixed by #18885
Closed
Tracked by #18584

NativeAOT: Do not root the framework assembly #18779

ivanpovazan opened this issue Aug 22, 2023 · 1 comment · Fixed by #18885
Assignees
@simonrozsival
Milestone
.NET 8

Comments

@ivanpovazan
Copy link
Member

Once all identified work regarding ILLink+ILC trimming compatibility has been completed rooting the framework assembly should not be needed anymore.

This means that we should remove the following lines and verify there are no regression when we do so:
https://github.com/xamarin/xamarin-macios/blob/596304e281c64c737c6b7a0f97fea2b0706671ae/dotnet/targets/Xamarin.Shared.Sdk.targets#L1235-L1236
@ivanpovazan ivanpovazan added this to the .NET 8 milestone Aug 22, 2023
@ivanpovazan ivanpovazan mentioned this issue Aug 22, 2023
Closed
5 tasks
@simonrozsival simonrozsival mentioned this issue Aug 23, 2023
Merged
rolfbjarne pushed a commit that referenced this issue Aug 23, 2023
@simonrozsival
Avoid using Activator.CreateInstance (#18795)
2aff4b5 
Ref #18779

- We can get rid of Activator.CreateInstance in
`DictionaryContainer.GetStrongDictionary<T>` by passing a factory method
- For the cases where we need to use Activator.CreateInstance we need to
add `[DynamicallyAccessedMembers(...)]` to the type parameter
@simonrozsival simonrozsival mentioned this issue Aug 31, 2023
Merged
@rolfbjarne rolfbjarne linked a pull request Sep 7, 2023 that will close this issue
[NativeAOT] Do not root platform assembly #18885
Merged
rolfbjarne pushed a commit that referenced this issue Sep 7, 2023
@simonrozsival
[NativeAOT] Do not root platform assembly (#18885)
aef2c91 
Closes #18779

Based on testing several MAUI samples, there doesn't seem to be a reason
to root the whole platform assembly anymore.
@rolfbjarne
Copy link
Member

Fixed in #18885.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonrozsival simonrozsival

Labels
None yet
Projects
None yet
Milestone
.NET 8
Development

Successfully merging a pull request may close this issue.

[NativeAOT] Do not root platform assembly simonrozsival/xamarin-macios
3 participants
@rolfbjarne @simonrozsival @ivanpovazan