Accessible grid sorting and filtering #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
=========================================
+ Coverage 98.63% 98.9% +0.26%
=========================================
Files 42 42
Lines 3013 3022 +9
Branches 811 814 +3
=========================================
+ Hits 2972 2989 +17
+ Misses 41 33 -8
Continue to review full report at Codecov.
|
agubler
approved these changes
Sep 20, 2018
| @@ -48,7 +51,7 @@ describe('Header', () => { | |||
| ); | |||
| h.expect(() => | |||
| v('div', { scrollLeft: 0, classes: [css.root, null], row: 'rowgroup' }, [ | |||
| v('div', { classes: css.row, role: 'role' }, [ | |||
| v('div', { classes: css.row, role: 'row' }, [ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug / feature
The following has been addressed in the PR:
Description:
Resolves #587
Things to follow up on:
searchthe correct input type for a filtering input?aria-labeloraria-labelledbyon the column header element.