Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TimePicker functional tests #368

Merged
merged 3 commits into from
Nov 13, 2017

Conversation

pottedmeat
Copy link
Contributor

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Wraps example tests with identifiers. Adds functional tests.

Resolves #162

@pottedmeat pottedmeat requested review from bitpshr and tomdye November 9, 2017 21:36
@codecov
Copy link

codecov bot commented Nov 9, 2017

Codecov Report

Merging #368 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files          25       25           
  Lines        1947     1947           
  Branches      494      494           
=======================================
  Hits         1904     1904           
  Misses         20       20           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1076e...654460b. Read the comment docs.

Copy link
Member

@bitpshr bitpshr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One subjective question about skip messages. Also, it was a little hard to read the diff since the indentation changed on the example page, but the code changes and added test look solid.

'validated inputs update on input'() {
const { browserName } = this.remote.session.capabilities;
if (browserName === 'internet explorer') {
this.skip('Test does not work on Internet Explorer');
Copy link
Member

@bitpshr bitpshr Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be more descriptive with the messages we pass when skipping tests? Do we know the level at which this test fails? Intern? Leadfoot? A driver? This is largely rhetorical, just trying to think of ways to make the skips less ugly.

This may be as good as we can do for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I'm able to easily find a reason in one of the other skips, I use it. Otherwise, trying to figure out the underlying cause is what had been holding up the tests, so I haven't been bothering anymore. I think the plan was to just skip with abandon then document and fix later.

@pottedmeat pottedmeat merged commit e2609c0 into dojo:master Nov 13, 2017
@pottedmeat pottedmeat deleted the timepicker-functional-tests branch November 13, 2017 16:34
@dylans dylans added this to the beta.4 milestone Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants