Textarea functional tests #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitpshr
approved these changes
Oct 26, 2017
smhigley
approved these changes
Oct 31, 2017
| }) | ||
| .end(); | ||
| }, | ||
| 'hidden label should not be displayed'() { |
There was a problem hiding this comment.
I'm not sure we need to add an example and test for this, since it's part of label functionality rather than textarea functionality (and I'm not a fan of hidden labels, so not big on modeling them in all the widget examples)
pottedmeat
force-pushed
the
textarea-functional-tests
branch
from
8a1229e to
8221990
Compare
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 25 25
Lines 1940 1940
Branches 491 491
=======================================
Hits 1897 1897
Misses 20 20
Partials 23 23Continue to review full report at Codecov.
|
tomdye
requested changes
Oct 31, 2017
src/textarea/example/index.ts
Outdated
| @@ -52,6 +54,7 @@ export class App extends WidgetBase<WidgetProperties> { | |||
| }), | |||
| v('h3', {}, ['Validated, Required Textarea']), | |||
| w(Textarea, { | |||
| extraClasses: { root: 't3' }, | |||
There was a problem hiding this comment.
same comment as others re. wrapping div with class rather than extraClasses.
tomdye
approved these changes
Nov 1, 2017
pottedmeat
force-pushed
the
textarea-functional-tests
branch
3 times, most recently
from
4c6d6c9 to
11334bb
Compare
pottedmeat
force-pushed
the
textarea-functional-tests
branch
from
11334bb to
745e838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Resolves #160