Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox unit tests updated to use test-extras #285

Merged
merged 2 commits into from
Sep 5, 2017

Conversation

smhigley
Copy link
Contributor

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Resolves #136

import * as css from '../../styles/checkbox.m.css';

const hasTouch = (function (): boolean {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about moving this has check somewhere global to all tests.

@codecov
Copy link

codecov bot commented Aug 23, 2017

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          24       24           
  Lines        1540     1540           
  Branches      452      452           
=======================================
  Hits         1525     1525           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc31fb4...b7d68d9. Read the comment docs.

@smhigley smhigley merged commit 328722d into dojo:master Sep 5, 2017
@dylans dylans added this to the 2017.09 milestone Sep 7, 2017
@smhigley smhigley deleted the checkbox-tests branch October 17, 2017 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants