Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textarea unit tests updated to use test-extras #284

Merged
merged 4 commits into from
Sep 5, 2017

Conversation

smhigley
Copy link
Contributor

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Resolves #146

@smhigley smhigley mentioned this pull request Aug 18, 2017
3 tasks
@smhigley smhigley requested review from bitpshr and agubler August 18, 2017 23:53
@codecov
Copy link

codecov bot commented Aug 19, 2017

Codecov Report

Merging #284 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          24       24           
  Lines        1540     1540           
  Branches      452      452           
=======================================
  Hits         1525     1525           
  Partials       15       15
Impacted Files Coverage Δ
src/textarea/Textarea.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc31fb4...c80560f. Read the comment docs.

@smhigley smhigley force-pushed the textarea-test-extras branch from b2a44ec to c80560f Compare August 31, 2017 16:24
@smhigley smhigley merged commit f6c851c into dojo:master Sep 5, 2017
@dylans dylans added this to the 2017.09 milestone Sep 7, 2017
@smhigley smhigley deleted the textarea-test-extras branch October 17, 2017 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants