Slider README #229
Merged
Slider README #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
======================================
Coverage 99.1% 99.1%
======================================
Files 23 23
Lines 1334 1334
Branches 401 401
======================================
Hits 1322 1322
Partials 12 12Continue to review full report at Codecov.
|
dylans
requested changes
Jun 8, 2017
src/slider/README.md
Outdated
| # Slider widget | ||
| # @dojo/widgets/slider/Slider widget | ||
|
|
||
| Dojo 2's `Slider` widget creates a range slider control with a styleable track, fill, and thumb. |
There was a problem hiding this comment.
Will everyone know what a thumb is?
src/slider/README.md
Outdated
|
|
||
| ### Accessibility Features | ||
|
|
||
| `Slider` uses the native `<input type="range">`as its base, which ensures built-in keyboard and screen reader accessibility. All common form field attributes (`disabled`, `invalid`, `readOnly`, `required`) may be set, as well as a visible or hidden label. The output node is associated with the input. |
There was a problem hiding this comment.
"The output node is associated with the input." I'm not sure most readers will know what is meant by this.
|
|
||
| The following CSS classes are available on the `Slider` widget for use with custom themes: | ||
|
|
||
| - `root`: Applied to either the wrapping `<label>`, or a `<div>` in the same position in the node hierarchy |
There was a problem hiding this comment.
Not essential but it might be nice to organize these into two sections (always, vs. conditional)?
mwistrand
approved these changes
Jun 9, 2017
dylans
approved these changes
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Resolves #189, adds Slider readme and fixes event typings on the example page.