Add ComboBox functional tests #128
Conversation
|
@mwistrand please update to use the css-modules class names to target nodes |
mwistrand
force-pushed
the
combobox-functional-tests
branch
from
ef67178 to
2e00348
Compare
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=========================================
+ Coverage 99.09% 99.1% +<.01%
=========================================
Files 19 19
Lines 999 1000 +1
Branches 300 300
=========================================
+ Hits 990 991 +1
Misses 1 1
Partials 8 8
Continue to review full report at Codecov.
|
|
@mwistrand you may still need to use |
mwistrand
force-pushed
the
combobox-functional-tests
branch
2 times, most recently
from
7273892 to
e62dbb8
Compare
| import * as keys from 'leadfoot/keys'; | ||
| import * as css from '../../styles/comboBox.m.css'; | ||
|
|
||
| const DELAY = 300; |
There was a problem hiding this comment.
Should we use a consistent value for the delay? (Not that it's wrong here, I've just seen 300, 400, and 500 in three different functional tests)
There was a problem hiding this comment.
It may need to be longer in other tests, but 300ms is enough here. I'd rather not make this one any longer than it has to be; if we can lower the others without the tests failing intermittently, then I would be fine with that.
|
@mwistrand this needs a rebase |
mwistrand
force-pushed
the
combobox-functional-tests
branch
from
e62dbb8 to
766b952
Compare
- Use SeleniumTunnel for tests. - Use CSS module for ComboBox functional tests. - Skip keyboard tests that do not work in FF. - Fix tests to execute more accurately across supported browsers.
- Do not run arrow key tests on touch devices or in Safari.
When the user interacts with the clear button, the widget should be invalidated regardless of whether the input value has changed.
mwistrand
force-pushed
the
combobox-functional-tests
branch
from
766b952 to
3a50d88
Compare
Type: bug / feature
The following has been addressed in the PR:
Description:
Adds basic functional tests for the
ComboBoxwidget, using the example page as the testing sandbox.Resolves #151