Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] Remove allowDirectBufferMapping config from Halo Online #4760

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Blisto91
Copy link
Contributor

Causes a black foliage issue on specific maps

See #4758

Causes a black foliage issue on specific maps
@Blisto91 Blisto91 marked this pull request as draft March 11, 2025 11:50
@Blisto91
Copy link
Contributor Author

Drafted as @K0bin would like to take a closer look first

@duckfudge
Copy link

The ElDewrito (Halo Online) community has been using d3d9.allowDirectBufferMapping = False for about 2 years now in its dxvk configs for a substantial performance gain - we've seen framerates shoot up from sub-30 fps to 60 fps.

Please don't merge this. We would rather keep the option to have better performance at the cost of worse visuals.

@dirkkane
Copy link

dirkkane commented Mar 11, 2025

The ElDewrito (Halo Online) community has been using d3d9.allowDirectBufferMapping = False for about 2 years now in its dxvk configs for a substantial performance gain - we've seen framerates shoot up from sub-30 fps to 60 fps.

Please don't merge this. We would rather keep the option to have better performance at the cost of worse visuals.

Agreed with Duck Fudge, Halo Online has a big community of people with low-end systems that rely on DXVK to boost the game to playable frame rates which this option provides, disabling it more or less nullifies our uses for DXVK. Some of us have been looking into fixes on the game's side but there's only so much we can do since the current version of the game is closed source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants