Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sso: add callout to certificate instructions #22193

Merged

Conversation

sarahsanders-docker
Copy link
Collaborator

Description

  • Good callout that we should clarify that copy/pasting the certificate values includes the ----BEGIN CERTIFICATE--- and ----END CERTIFICATE---- lines. This applies to both Okta and Entra examples, as confirmed in my test org
  • I will pass on to IAM about adding placeholder text, I think would be more valuable than an example in docs

Related issues or tickets

#22176 (comment)

Reviews

  • Editorial review

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
arvid-norlander Arvid Norlander
Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 20e2f99
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67cb167e6eab0e00088a5986
😎 Deploy Preview https://deploy-preview-22193--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarahsanders-docker sarahsanders-docker merged commit fee0d8b into docker:main Mar 7, 2025
14 checks passed
@sarahsanders-docker sarahsanders-docker linked an issue Mar 7, 2025 that may be closed by this pull request
1 task
mdelapenya added a commit to mdelapenya/docker-docs that referenced this pull request Mar 11, 2025
* main: (42 commits)
  Update image source for kafbat
  Add missing release note to Docker Desktop release notes (docker#22218)
  Update build-summary.md
  feedback link fix: (docker#22212)
  some clarification on additional_contexts (docker#22204)
  Update windows-install.md (docker#22184)
  sso: add callout to certificate instructions (docker#22193)
  chore: cleanup includes w/ embedded shortcodes (docker#22191)
  fix: rendering issue w/ experimental labs include (docker#22190)
  billing: improve docs for manual payment retries (docker#22181)
  build: fix intro of distributed build section (docker#22189)
  dd-cli-cicd-fix (docker#22187)
  Update release note for 4.39 (docker#22188)
  Change directory after pulling a sample Docker application (docker#22179)
  Merge pull request docker#22117 from aevesdocker/ENGDOCS-2451
  fix: troubleshooting toc fix (docker#22166)
  Add security section to 4.39.0 release notes (docker#22178)
  Merge pull request docker#22175 from aevesdocker/ENGDOCS-2470
  Merge pull request docker#22160 from sarahsanders-docker/tcc-minutes
  hub: add troubleshooting (docker#22157)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected formatting of x509 certificate content not clear
2 participants