Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2934: Show only one tooltip on events' date-icon #3170

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hannaseithe
Copy link
Contributor

Short Description

When hovering over the events' date-icon we show only one tooltip

Proposed Changes

  • the problem was that inside EventListItem Component we did not ascribe a unique id to the tooltip
  • in order to generate a unique id I hand in the index from the list of events to a singular item, which then can be used to generate a uniqueId
  • (the alternative solution of generating a uniqueId from the events._path property I chose not to implement, since we currently do not guarantee that the path is unique (see: #3060)

Side Effects

  • ListComponent
  • EventsPage
  • EventsListItem

Testing

Resolved Issues

Fixes: #2934


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some recurring icons at events have overlapping tooltips
1 participant