Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3166: Use matrix jobs in CI #3167

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

3166: Use matrix jobs in CI #3167

wants to merge 4 commits into from
+250 −1,236

Conversation

steffenkleinle
Copy link
Member

@steffenkleinle steffenkleinle commented Mar 25, 2025 •
edited
Loading

Short Description

Use matrix jobs in CI to simplify workflows.

Proposed Changes

  • Use matrix jobs in CI workflows
  • Improve readability by fixed order of job properties and removal of explicit name properties
  • Remove redundant/outdated workflow config version
  • Use unused skip_job command to fix failing CI

Side Effects

N/A

Testing

See that the CI succeeds: https://app.circleci.com/pipelines/github/digitalfabrik/integreat-app/13217/workflows/e281cb62-ac04-424f-9611-69c54fa6ce72

🤞 for promotion and delivery :)

Resolved Issues

Fixes: #3166

@steffenkleinle steffenkleinle marked this pull request as ready for review March 25, 2025 12:23
bahaaTuffaha
bahaaTuffaha approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@bahaaTuffaha bahaaTuffaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 🙂

  • Not sure what skip_job does or why its removed.

@steffenkleinle
Copy link
Member Author

Not sure what skip_job does or why its removed.

See the corresponding (now deleted) section in the docs. But basically it was a way to prevent the CI from executing specific jobs. However, it never really worked well (due repeated execution of jobs with different build configs) and was not used in the last year. Therefore I chose to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahaaTuffaha bahaaTuffaha bahaaTuffaha approved these changes

@f1sh1918 f1sh1918 Awaiting requested review from f1sh1918 f1sh1918 is a code owner

@LeandraH LeandraH Awaiting requested review from LeandraH LeandraH is a code owner

@lunars97 lunars97 Awaiting requested review from lunars97 lunars97 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use matrix jobs in CI
2 participants
@steffenkleinle @bahaaTuffaha