-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3104: Improve bottomSheet accessibility #3153
base: main
Are you sure you want to change the base?
Conversation
I think this would be okay as we explicitly exclude the map from being accessible in our accessibility declaration as maps are just by design not really accessible. So feel free to implement this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested, nice work.
Short Description
Make the BottomSheet Slider in Pois accessible to screen readers
Add announcement to the main component when focused by adding accessibilityHint with sth like Locations near you (currently it is announcing BottomSheet Slider) and add announcement on how many items are in the list.
Proposed Changes
Noticable problems:
First of all I can't change the "BottomSheet Slider" accessibility label from
PoisBottomSheet
. I had an idea of using patch-package to change this label but it could be bad idea for reusability.The other difficulty is trying to make the bottom-sheet easier to be selected by the screen reader because it's tricky to select the bottom-sheet by tapping (the selection will go to the map behind) at android so I found out the only way is to disable the map's accessibility by using
importantForAccessibility='no'
.Note: not tested on iOS.
Side Effects
Testing
(while using talkback swipe left/right to reach the list if it's hard to tap it)
Resolved Issues
Fixes: #3104