Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3104: Improve bottomSheet accessibility #3153

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

bahaaTuffaha
Copy link
Contributor

@bahaaTuffaha bahaaTuffaha commented Mar 14, 2025

Short Description

Make the BottomSheet Slider in Pois accessible to screen readers

Add announcement to the main component when focused by adding accessibilityHint with sth like Locations near you (currently it is announcing BottomSheet Slider) and add announcement on how many items are in the list.

Proposed Changes

Noticable problems:
First of all I can't change the "BottomSheet Slider" accessibility label from PoisBottomSheet. I had an idea of using patch-package to change this label but it could be bad idea for reusability.

The other difficulty is trying to make the bottom-sheet easier to be selected by the screen reader because it's tricky to select the bottom-sheet by tapping (the selection will go to the map behind) at android so I found out the only way is to disable the map's accessibility by using importantForAccessibility='no'.

  • Added an accessibilityLabel to announce number of locations near the user.
  • Included translations.

Note: not tested on iOS.

Side Effects

  • none

Testing

  • Enable talkback.
  • Go to pois/map and check the list.
    (while using talkback swipe left/right to reach the list if it's hard to tap it)

Resolved Issues

Fixes: #3104


@steffenkleinle steffenkleinle changed the title 3104: Improving bottomSheet's accessibility 3104: Improve bottomSheet accessibility Mar 17, 2025
@steffenkleinle
Copy link
Member

The other difficulty is trying to make the bottom-sheet easier to be selected by the screen reader because it's tricky to select the bottom-sheet by tapping (the selection will go to the map behind) at android so I found out the only way is to disable the map's accessibility by using importantForAccessibility='no'.

I think this would be okay as we explicitly exclude the map from being accessible in our accessibility declaration as maps are just by design not really accessible. So feel free to implement this.

Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make BottomSheet Slider in Pois accessible for screen readers
3 participants