3128: Fix promotion messages being posted to the wrong mattermost channel #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunars97
requested review from
steffenkleinle,
f1sh1918,
LeandraH and
bahaaTuffaha
as code owners
lunars97
commented
Mar 5, 2025
steffenkleinle
requested changes
Mar 6, 2025
lunars97
force-pushed
the
3128-fix-promotion-messages-posted-to-wrong-mattermost-channel
branch
5 times, most recently
from
fa7c2f4 to
983fe8c
Compare
…nnel 3128: Apply suggestions
lunars97
force-pushed
the
3128-fix-promotion-messages-posted-to-wrong-mattermost-channel
branch
from
983fe8c to
f4804cb
Compare
lunars97
commented
Mar 23, 2025
| Send_notification $1 $2 "$3" |
There was a problem hiding this comment.
That's a prettier change to have an empty line at the end of the file. In case you were wondering why there is a change here 😅
…mattermost-channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Promotion messages and releases are being posted on ~integreat-app-notifications channel instead of being posted on ~releases
Proposed Changes
Side Effects
Mattermost channel
Testing
not testable, can be seen if it will be posted on the related channel
Resolved Issues
Fixes: #3128